Page MenuHomePhabricator

Remove SingleNodeConnCB
ClosedPublic

Authored by schancel on Jan 16 2018, 07:21.

Details

Summary

This commit merges the NodeConnCB and SingleNodeConnCB into a single
class (called NodeConnCB). The original intent for the NodeConnCB was to
be able to have a python 'mininode' connect to multiple running
bitcoinds. This has never been used and can be achieved more easily by
having multiple NodeConns backed by a common datastore if it is ever
needed.

The changes in mininode.py are just code moves (and merging the two
classes into a single class). The code changes in the individual test
cases are changing the subclasses to subclass from NodeConnCB instead of
SingleNodeConnCB. There is a lot of duplicate code in the subclasses
that can be removed in future commits.

Backport of Core PR10109, Fixes T143

Test Plan

Run functional tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D968
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1652
Build 1652: arc lint + arc unit

Event Timeline

Fix abc-p2p-fullblocktest

deadalnix requested changes to this revision.Jan 17 2018, 23:15
deadalnix added inline comments.
test/functional/assumevalid.py
61 ↗(On Diff #2552)

This clearly doesn't match what's in the PR. I think you are missing D974 .

This revision now requires changes to proceed.Jan 17 2018, 23:15
This revision is now accepted and ready to land.Jan 18 2018, 02:23
deadalnix edited reviewers, added: schancel; removed: deadalnix.
This revision now requires review to proceed.Jan 18 2018, 02:23
schancel edited reviewers, added: deadalnix; removed: schancel.
This revision is now accepted and ready to land.Jan 19 2018, 02:01
This revision was automatically updated to reflect the committed changes.