Page MenuHomePhabricator
Differential D988

[backport] Reject invalid wallets
ClosedPublic
Actions

Authored by schancel on Jan 20 2018, 06:27.

Details

Reviewers
deadalnix
jasonbcox
matiu
Group Reviewers
Restricted Project
Maniphest Tasks
T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test
T190: Backport Core PR10885: Reject invalid wallets
Commits
rSTAGING8a35da7fd454: [backport] Reject invalid wallets
rABC8a35da7fd454: [backport] Reject invalid wallets
Summary

Backport of Bitcoin Core PR#10885: Reject invalid wallets

d84e78e [wallet] Specify wallet name in wallet loading errors (John Newbery)
a6da027 Reject invalid wallet files (João Barbosa)
3ef77a0 Reject duplicate wallet filenames (João Barbosa)

Pull request description:

This PR prevents loading the same wallet more than once in a multi wallet scenario. It also prevents loading with invalid files: non regular files or symlinks.

Depends on D987
Closes T190

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
depends-on-D987
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1692
Build 1692: arc lint + arc unit

Event Timeline

schancel created this revision.Jan 20 2018, 06:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2018, 06:27
schancel retitled this revision from Reject invalid wallets to [backpor] Reject invalid wallets.Jan 20 2018, 06:28
schancel edited the test plan for this revision. (Show Details)
teamcity added a subscriber: teamcity.Jan 20 2018, 06:29

Build https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=829 started.

schancel edited the summary of this revision. (Show Details)Jan 20 2018, 06:32
schancel retitled this revision from [backpor] Reject invalid wallets to [backport] Reject invalid wallets.
teamcity added a comment.Jan 20 2018, 06:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2626.Jan 21 2018, 02:18

Fix a few problems

Harbormaster completed remote builds in B1688: Diff 2626.Jan 21 2018, 02:18
teamcity added a comment.Jan 21 2018, 02:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 02:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2630.Jan 21 2018, 02:55

Rebase

teamcity added a comment.Jan 21 2018, 03:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 03:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2634.Jan 21 2018, 03:46

Rebase

teamcity added a comment.Jan 21 2018, 03:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 04:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel updated this revision to Diff 2637.Jan 21 2018, 09:14

Rebase

Harbormaster completed remote builds in B1699: Diff 2637.Jan 21 2018, 09:14
teamcity added a comment.Jan 21 2018, 09:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 09:25

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

matiu requested changes to this revision.Jan 21 2018, 14:36
matiu added inline comments.
test/functional/test_framework/test_framework.py
39 ↗(On Diff #2626)

This is already at line 37.

This revision now requires changes to proceed.Jan 21 2018, 14:36
schancel updated this revision to Diff 2648.Jan 21 2018, 19:43

Rebase

teamcity added a comment.Jan 21 2018, 19:44

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 2649.Jan 21 2018, 19:54

Remove extra start_node

schancel updated this revision to Diff 2650.Jan 21 2018, 19:56

Remove changes to test_framework

teamcity added a comment.Jan 21 2018, 20:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 20:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Jan 21 2018, 20:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 20:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Jan 21 2018, 20:25

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel updated this revision to Diff 2657.Jan 21 2018, 23:06

Rebase

Harbormaster completed remote builds in B1714: Diff 2657.Jan 21 2018, 23:06
teamcity added a comment.Jan 21 2018, 23:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 21 2018, 23:29

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel added inline comments.Jan 22 2018, 16:06
src/wallet/wallet.cpp
529 ↗(On Diff #2657)

Should be fs::

deadalnix accepted this revision.Jan 22 2018, 16:22
deadalnix added inline comments.
src/wallet/wallet.cpp
529 ↗(On Diff #2657)

Yes please.

schancel edited the summary of this revision. (Show Details)Jan 22 2018, 18:45
schancel added tasks: T190: Backport Core PR10885: Reject invalid wallets, T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
schancel updated this revision to Diff 2679.Jan 22 2018, 19:05

boost::filesystem:: -> fs::

Harbormaster completed remote builds in B1724: Diff 2679.Jan 22 2018, 19:05
schancel edited the summary of this revision. (Show Details)Jan 22 2018, 19:06
teamcity added a comment.Jan 22 2018, 19:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 22 2018, 19:29

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

matiu resigned from this revision.Jan 23 2018, 00:09
This revision is now accepted and ready to land.Jan 23 2018, 00:09
Closed by commit rABC8a35da7fd454: [backport] Reject invalid wallets (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by schancel). · Explain WhyJan 23 2018, 00:38
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
35 lines
test/
functional/
27 lines
test_framework/
2 lines

Diff 2630

View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/multiwallet.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...