Page MenuHomePhabricator
Differential D10370

[avalanche] Clarify the proof accessor API
ClosedPublic
Actions

Authored by Fabien on Oct 21 2021, 13:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCf03a3e0c3b3c: [avalanche] Clarify the proof accessor API
Summary

The getProof() and exists() methods only target valid proof and not the orphans. This diff changes this API so it is easier to retrieve any known proof from its ID.

Ref T1854.

Test Plan
ninja check-extended

Diff Detail

Event Timeline

Fabien created this revision.Oct 21 2021, 13:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2021, 13:42
Fabien requested review of this revision.Oct 21 2021, 13:42
Harbormaster completed remote builds in B17080: Diff 30620.Oct 21 2021, 13:56
Fabien added a child revision: D10377: [avalanche] Orphan the conflicting proofs rather than ignoring them.Oct 21 2021, 15:48
deadalnix requested changes to this revision.Oct 21 2021, 20:13
deadalnix added a subscriber: deadalnix.

Overall, lgtm. This is indeed much better.

I don't think the use a forPeer is very judicious, though. It obfuscate the code more than anything else.

src/avalanche/peermanager.cpp
228

That seems to be a very convoluted way to do

auto &pview = peers.get<proof_index>();
return pview.find(proofid) != pview.end();
This revision now requires changes to proceed.Oct 21 2021, 20:13
Fabien updated this revision to Diff 30644.Oct 22 2021, 08:00

Don't use forPeer() when there is nothing to do on the peer

Harbormaster completed remote builds in B17103: Diff 30644.Oct 22 2021, 08:14
Fabien added a child revision: D10383: [avalanche] Remove the invalid peers before the orphans rescan.Oct 22 2021, 08:32
Fabien removed a child revision: D10377: [avalanche] Orphan the conflicting proofs rather than ignoring them.Oct 22 2021, 08:41
deadalnix accepted this revision.Oct 25 2021, 21:12
This revision is now accepted and ready to land.Oct 25 2021, 21:12
Closed by commit rABCf03a3e0c3b3c: [avalanche] Clarify the proof accessor API (authored by Fabien). · Explain WhyOct 26 2021, 07:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf03a3e0c3b3c: [avalanche] Clarify the proof accessor API.

Revision Contents
Changeset List

PathSize
src/
avalanche/
5 lines
26 lines
test/
59 lines
12 lines
rpc/
8 lines

Diff 30620

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...