[rpc] allow multiple txns in testmempoolaccept
ClosedPublic
Actions

Authored by PiRK on Oct 3 2022, 16:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf0d9880cdc7e: [rpc] allow multiple txns in testmempoolaccept

Summary

Only allow "packages" with no conflicts, sorted in order of dependency,
and no more than 25 for now. Note that these groups of transactions
don't necessarily need to adhere to some strict definition of a package
or have any dependency relationships. Clients are free to pass in a
batch of 25 unrelated transactions if they want to.

This is a backport of core#20833 [10 & 12/13] and core#22084 [2 & 3/4]
https://github.com/bitcoin/bitcoin/pull/20833/commits/9ede34a6f20378e86c5289ebd20dd394a5915123
https://github.com/bitcoin/bitcoin/pull/22084/commits/7d91442461776e2ef240d7885f768b624de341a7
https://github.com/bitcoin/bitcoin/pull/22084/commits/e8ecc621be6afd3252c0f8147e42c3b4918f7f46 (partial)
https://github.com/bitcoin/bitcoin/pull/20833/commits/9ef643e21b44f99f4bce54077788d0ad4d81f7cd (release notes)

Depends on D12124

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 3 2022, 16:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2022, 16:38

PiRK requested review of this revision.Oct 3 2022, 16:38

teamcity edited the summary of this revision. (Show Details)Oct 3 2022, 16:38

PiRK added a child revision: D12126: [test] functional test for packages in RPCs.Oct 3 2022, 16:40

Harbormaster completed remote builds in B20298: Diff 35361.Oct 3 2022, 17:26

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

rebase

Harbormaster completed remote builds in B20326: Diff 35393.Oct 4 2022, 09:04

Fabien requested changes to this revision.Oct 4 2022, 14:46

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/rpc/rawtransaction.cpp
1076 ↗	(On Diff #35393)	or not :)
1168 ↗	(On Diff #35393)	? Not sure what's the point is. Where does it comes from ?
1246 ↗	(On Diff #35393)	Can be moved ? Answer to self: no, but would be nice to add this to UniValue

This revision now requires changes to proceed.Oct 4 2022, 14:46

PiRK added inline comments.Oct 4 2022, 17:52

src/rpc/rawtransaction.cpp
1168 ↗	(On Diff #35393)	I'm going to remove this. It was introduced in a segwit related pull request on the core side https://github.com/bitcoin/bitcoin/pull/19836/commits/33330778230961cfbf2a24de36b5877e395cc596