As per title.
Details
Details
- Reviewers
deadalnix jasonbcox mbhinder jimpo matiu Mengerian - Group Reviewers
Restricted Project - Commits
- rSTAGING81c8fef18aeb: Update developer notes and link to it from contributing docs
rABC81c8fef18aeb: Update developer notes and link to it from contributing docs
Read the documentatino
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- style-guide
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2369 Build 2872: Bitcoin ABC Buildbot (legacy) Build 2871: arc lint + arc unit
Event Timeline
| doc/developer-notes.md | ||
|---|---|---|
| 28 ↗ | (On Diff #3550) | Curly braces should be on the same line as the definition. Same goes for lines below this one. |
| 53 ↗ | (On Diff #3550) | Rather than what this code does, perhaps "Comment summarizing the intended purpose of this section of code". Unless the code is particularly difficult to parse, describing what it does is a bit redundant. The intended purpose is often very similar to what it does, but we all know that isn't always the case. :P |
| 324 ↗ | (On Diff #3550) | Should we leave this in until T214 is completed? |
| doc/developer-notes.md | ||
|---|---|---|
| 18 ↗ | (On Diff #3550) | Remove the allowance for single-line if statements. |
| 39 ↗ | (On Diff #3550) | Presumably lowerCamelCase for local variables too? Can we document that somewhere? |
| 44 ↗ | (On Diff #3550) | Can you make it explicit that this applies to both functions and class methods? |
| 56 ↗ | (On Diff #3550) | Braces. |
Comment Actions
One last clarification on block statements and I think it's good. :)
| doc/developer-notes.md | ||
|---|---|---|
| 18 ↗ | (On Diff #3554) | These are called "block statements". We can clarify this by saying:
|
| doc/developer-notes.md | ||
|---|---|---|
| 27 ↗ | (On Diff #3575) | This isn't a formating rule. While this is a good rule, it has nothing to do burried in the middle of formatting rules. |