Paths

Table of Contentst

Differential D12663

[Cashtab] Deprecate BCH param from generateTxInput function
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 05:54.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd90f153e17d2: [Cashtab] Deprecate BCH param from generateTxInput function

Summary

T2730

Remove BCH param from generateTxInput function

The param is not currently used in the function.

Test Plan

npm start and send an XEC tx
npm test
grep -r generateTxInput src/ and make sure all instances have been addressed

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21235
Build 42122: Build Diff	cashtab-tests
Build 42121: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 28 2022, 05:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 05:54

bytesofman requested review of this revision.Nov 28 2022, 05:54

Harbormaster completed remote builds in B21204: Diff 36730.Nov 28 2022, 05:57

bytesofman added a child revision: D12664: [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function.Nov 28 2022, 05:58

rebase

Harbormaster completed remote builds in B21235: Diff 36770.Nov 29 2022, 10:03

emack accepted this revision.Nov 29 2022, 13:42

This revision is now accepted and ready to land.Nov 29 2022, 13:42

Closed by commit rABCd90f153e17d2: [Cashtab] Deprecate BCH param from generateTxInput function (authored by bytesofman). · Explain WhyNov 29 2022, 15:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd90f153e17d2: [Cashtab] Deprecate BCH param from generateTxInput function.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

1 line

utils/

__tests__/

cashMethods.test.js

10 lines

txBuilder.test.js

1 line

cashMethods.js

2 lines

Diff 36770

View Options

web/cashtab/src/hooks/useBCH.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/tests/txBuilder.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from generateTxInput functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36770

web/cashtab/src/hooks/useBCH.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/__tests__/txBuilder.test.js

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from generateTxInput function
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/utils/tests/cashMethods.test.js

web/cashtab/src/utils/tests/txBuilder.test.js