Remove sunsetted op_return replay protection
ClosedPublic
Actions

Authored by deadalnix on May 14 2018, 05:52.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING09ec5e96fe9e: Remove sunsetted op_return replay protection
rABC09ec5e96fe9e: Remove sunsetted op_return replay protection

Summary

We now passed the sunset height, so this is not necessary anymore

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

removeopreturnreplay

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2580
Build 3276: Bitcoin ABC Buildbot (legacy)
Build 3275: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 14 2018, 05:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2018, 05:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2580: Diff 3882.May 14 2018, 06:18

jasonbcox accepted this revision.May 14 2018, 06:34

This revision is now accepted and ready to land.May 14 2018, 06:34

Closed by commit rABC09ec5e96fe9e: Remove sunsetted op_return replay protection (authored by deadalnix). · Explain WhyMay 14 2018, 10:47

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in D15036: remove unused CScript::IsCommitment.Dec 22 2023, 09:30

PiRK mentioned this in rABC4c471387d04b: remove unused CScript::IsCommitment.Dec 22 2023, 09:52

Revision Contents
Changeset List

Path

Size

src/

Makefile.test.include

2 lines

chainparams.cpp

15 lines

consensus/

params.h

4 lines

test/

CMakeLists.txt

2 lines

script_antireplay_tests.cpp

script_commitment_tests.cpp

62 lines

validation.cpp

14 lines

Diff 3882

View Options

src/Makefile.test.include

View Options

src/chainparams.cpp

View Options

src/consensus/params.h

View Options

src/test/CMakeLists.txt

View Options

src/test/script_antireplay_tests.cpp

View Options

src/test/script_commitment_tests.cpp

View Options

Remove sunsetted op_return replay protectionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3882

src/Makefile.test.include

src/chainparams.cpp

src/consensus/params.h

src/test/CMakeLists.txt

src/test/script_antireplay_tests.cpp

src/test/script_commitment_tests.cpp

src/validation.cpp

Remove sunsetted op_return replay protection
ClosedPublic
Actions

Revision Contents
Changeset List