In addition, stop enforcing transaction ordering for RollforwardBlock by adding coin and spending them in two passes.
Depends on D1478
Details
Details
- Reviewers
jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGINGfa411b712945: Separate adding and spending coins for a given transaction.
rABCfa411b712945: Separate adding and spending coins for a given transaction.
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- txorder
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2704 Build 3520: Bitcoin ABC Buildbot (legacy) Build 3519: arc lint + arc unit
Event Timeline
| src/validation.cpp | ||
|---|---|---|
| 1480–1486 | This block is not consistent with the other UpdateCoins() function. Shouldn't this be encapsulated in another SpendCoins() function, but without the CTxUndo param? As a side effect, the tx.IsCoinBase() check can be separated rather than wrapping the rest of the logic. | |
| 2264 | Why split this apart? Do you plan on removing UpdateCoin() all together? | |
| src/validation.cpp | ||
|---|---|---|
| 1480–1486 | Why isn't it consistent ? It does the same, without updating the undo datastructure. | |
| 2264 | The goal of this refactoring is to get to a position where we add the output in one pass and then mark the coin spent in a second pass. Separating adding and spending is the first step toward this. RollforwardBlock already does it in two passes, but ConnectBlock require some more refactoring and some activation mechanism before it can do it. | |