Differential D1524

Various nits in validation.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 30 2018, 20:32.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING85ea4054dc57: Various nits in validation.cpp
rABC85ea4054dc57: Various nits in validation.cpp

Summary

Mostly giving the code some breathing room, but also adding C++11 loops.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

validationnits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2776
Build 3662: Bitcoin ABC Buildbot (legacy)
Build 3661: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 30 2018, 20:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2018, 20:32

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2776: Diff 4170.Jun 30 2018, 21:06

deadalnix retitled this revision from Variosu nits in validation.cpp to Various nits in validation.cpp.Jun 30 2018, 23:36

deadalnix added a child revision: D1528: Update ApplyBlockUndo to be able to undo out of order blocks..Jul 1 2018, 19:12

schancel accepted this revision.Jul 2 2018, 15:12

This revision is now accepted and ready to land.Jul 2 2018, 15:12

Closed by commit rABC85ea4054dc57: Various nits in validation.cpp (authored by deadalnix). · Explain WhyJul 2 2018, 23:07

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

133 lines

Diff 4170

src/validation.cpp

Loading...