Page MenuHomePhabricator
Differential D1578

Refactor signature encoding checks to separates checks of the SigHashType and other checks
ClosedPublic
Actions

Authored by deadalnix on Jul 18 2018, 01:05.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING22a85fdccbb1: Refactor signature encoding checks to separates checks of the SigHashType and…
rABC22a85fdccbb1: Refactor signature encoding checks to separates checks of the SigHashType and…
Summary

This is done via slicing the sig to remove the SigHashType. Hopefully, the next step is to expose an API to check signature without the SigHashType which will allow to reduce the test time dramatically.

Depends on D1577

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkwithsighash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2895
Build 3894: Bitcoin ABC Buildbot (legacy)
Build 3893: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 18 2018, 01:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2018, 01:05
teamcity added a subscriber: teamcity.Jul 18 2018, 01:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 18 2018, 02:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2894: Diff 4344.Jul 18 2018, 02:06
deadalnix updated this revision to Diff 4345.Jul 18 2018, 11:59

Rename the funcion to CheckTransactionSignatureEncoding and add a doc comment.

teamcity added a comment.Jul 18 2018, 12:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 18 2018, 12:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2895: Diff 4345.Jul 18 2018, 12:57
deadalnix updated this revision to Diff 4346.Jul 18 2018, 13:37

Improve comments.

teamcity added a comment.Jul 18 2018, 13:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4347.Jul 18 2018, 13:40

Rename the function checking the signature itself into CheckRawSignatureEncoding

teamcity added a comment.Jul 18 2018, 13:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2896: Diff 4346.Jul 18 2018, 14:38
teamcity added a comment.Jul 18 2018, 14:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2897: Diff 4347.Jul 18 2018, 14:41
teamcity added a comment.Jul 18 2018, 14:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1579: Add CheckDataSignatureEncoding to check signature with a sighashtype..Jul 18 2018, 14:49
deadalnix updated this revision to Diff 4349.Jul 18 2018, 14:59

Various nits

teamcity added a comment.Jul 18 2018, 14:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 18 2018, 15:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2899: Diff 4349.Jul 18 2018, 15:58
jasonbcox accepted this revision.Jul 23 2018, 14:52
This revision is now accepted and ready to land.Jul 23 2018, 14:52
Closed by commit rABC22a85fdccbb1: Refactor signature encoding checks to separates checks of the SigHashType and… (authored by deadalnix). · Explain WhyJul 23 2018, 17:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
script/
7 lines
9 lines
41 lines
test/
16 lines

Diff 4345

View Options

src/core_write.cpp

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/sigencoding.h

Loading...
View Options

src/script/sigencoding.cpp

Loading...
View Options

src/test/sigencoding_tests.cpp

Loading...