Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGf708ac3e18c7: Fixed logging block diff times so that the order of blocks being received…
rABCf708ac3e18c7: Fixed logging block diff times so that the order of blocks being received…

Summary

Discovered this while debugging tests for D1442.

Test Plan

With D1442 applied:
build/test/functional/test_runner.py sendheaders-selfish-mining.py and
examine the logs at /tmp/bitcoin_test_runner_xxx/sendheaders-selfish-mining_xxx/node0/regtest/debug.log.

Note that the tmp files get cleaned up if the test passes, so make it fail
with assert() at the end of sendheaders-selfish-mining.py to see these logs.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

D1511-reduced

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2974
Build 4046: Bitcoin ABC Buildbot (legacy)
Build 4045: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 22 2018, 00:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2018, 00:12

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Forgot to remove the assert() in the test

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2760: Diff 4153!Jun 22 2018, 00:46

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2759: Diff 4152!Jun 22 2018, 00:48

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2760: Diff 4153.Jun 22 2018, 21:52

jasonbcox added a child revision: D1515: Updated release notes to reflect recent work on selfish mining changes.Jun 25 2018, 17:18

deadalnix accepted this revision.Jun 30 2018, 14:23

This revision is now accepted and ready to land.Jun 30 2018, 14:23

Feedback from D1515: moved one of the release notes to this diff.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2890: Diff 4334!Jul 17 2018, 16:02

jasonbcox requested review of this revision.Jul 17 2018, 16:35

jasonbcox edited the summary of this revision. (Show Details)

jasonbcox added a parent revision: D1442: Discourage selfish mining by favoring blocks with more accurate timestamps.

Since the dependent diff is constantly slipping off my plate, I'm going to split this into two changes. Some of those changes belong in D1442 itself while the rest can be committed without a dependency.