Details
Details
- Reviewers
jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING9ba4bfca513d: Implement OP_CHECKDATASIG and OP_CHECKDATASIGVERIFY
rABC9ba4bfca513d: Implement OP_CHECKDATASIG and OP_CHECKDATASIGVERIFY
Added a ton of test cases.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- checkdatasig
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3014 Build 4121: Bitcoin ABC Buildbot (legacy) Build 4120: arc lint + arc unit
Event Timeline
| src/test/checkdatasig_tests.cpp | ||
|---|---|---|
| 108 ↗ | (On Diff #4506) | epxected -> expected |
Comment Actions
I've gone over this diff twice now. It's quite large, but looks pretty great so far. Should be good once PushSig is clarified. It took me 10-20 minutes to figure out what was going on there.
| src/test/script_tests.cpp | ||
|---|---|---|
| 345 ↗ | (On Diff #4506) | This needs some differentiation from the other PushSig(), since the other one always includes the SigHashType. Differentiation can be either a rename from PushSig() to PushSigWithoutHashType() or just adding a comment that explains that SigHashType is not appended when hash is provided directly. |
| 1206 ↗ | (On Diff #4506) | TestBuilder's API is hilariously weird. Opened up a few tasks to fix that so it makes more sense: https://reviews.bitcoinabc.org/T392 |