The ECKey class is about to be replaced. And we don't need a private key to verify a message anyway.
Depends on D16351
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address
python test_runner.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29357 Build 58250: Build Diff electrum-tests Build 58249: arc lint + arc unit
Event Timeline
| electrum/electrumabc/ecc.py | ||
|---|---|---|
| 291 ↗ | (On Diff #48300) | similar change of behavior as D16351, we no longer raise errors from pubkey_from_signature on malformed signatures, we just return false. So sign_message below no longer needs to catch the error (and now actually checks the return value of verify_message) |