Page MenuHomePhabricator
Differential D1749

net: use an interface class rather than signals for message processing
ClosedPublic
Actions

Authored by deadalnix on Sep 10 2018, 12:33.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING444640f43967: net: use an interface class rather than signals for message processing
rABC444640f43967: net: use an interface class rather than signals for message processing
Summary

Drop boost signals in favor of a stateful class. This will allow the message
processing loop to actually move to net_processing in a future step.

This is part of core PR10756

Depends on D1744 and D1748

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr10756
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3259
Build 4605: Bitcoin ABC Buildbot (legacy)
Build 4604: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 10 2018, 12:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 12:33
teamcity added a subscriber: teamcity.Sep 10 2018, 12:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4835.Sep 10 2018, 12:44

Finalize the backport as next commits are trivial

teamcity added a comment.Sep 10 2018, 12:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 13:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3242: Diff 4834.Sep 10 2018, 13:10
teamcity added a comment.Sep 10 2018, 13:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3243: Diff 4835!Sep 10 2018, 13:21
schancel accepted this revision.Sep 10 2018, 20:41
schancel added a subscriber: schancel.

Was there ever a reason for multiple signal handlers to be registered at the same time? I suppose that could still be done with a wrapper...

This revision is now accepted and ready to land.Sep 10 2018, 20:41
deadalnix updated this revision to Diff 4866.Sep 10 2018, 22:15

rebase

teamcity added a comment.Sep 10 2018, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 23:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3259: Diff 4866.Sep 10 2018, 23:23
Closed by commit rABC444640f43967: net: use an interface class rather than signals for message processing (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 10 2018, 23:33
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D2909: Merge #11238: Add assertions before potential null deferences.May 2 2019, 21:01
Fabien mentioned this in D11298: Remove duplicated (and misplaced) node disconnection logging.Apr 3 2022, 08:58
Fabien mentioned this in rABC26e7529b03ec: Remove duplicated (and misplaced) node disconnection logging.Apr 3 2022, 19:06

Revision Contents
Changeset List

PathSize
src/
7 lines
33 lines
22 lines
54 lines
144 lines
test/
22 lines
2 lines
6 lines

Diff 4866

View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/DoS_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...