Pass the config down.

It doesn't looks like this belongs here.

Why is this public ?

There is no reason to create that dependency. In fact, there is probably no reason to change this file at all.

???

Ok I'll try

what? the check on string length?

to unit test, but I suppose there's to be a way to unit test also private function

it's a left over, need to be removed.

another left over

do you want me to extract the len check from userAgent()?

doing that would make the code a little bit cumbersome cause every time we call the function we have to check for its res len and shrink it if to long...

to use std::fesetround(FE_DOWNWARD) and std::fesetround(FE_TONEAREST);
this is the kludge that need to go mentioned in my last comment

userAgent() is tested already in the functional test contained in abc-cmdline.py and abc-rpc.py, freetrader asked for a unit test for getSubVerEB and I added it.

And such test help me find it a round bug. In any case you are right, I'm going to move what I'm testing in src/test/net_tests.cpp to abc-rpc.py

I could swear I did it... never mind I'll remove it for good in the next iteration

We shouldn't be using floating point at all for anything consensus related.

Also, presumably, this should be removed from somewhere else.

What's tested for these is that the user agent come out the right way. This is an integration test. Here we want a unit test: given a specific config, what UA is generated.

I purposely set a higher precision than what we need. 2 rather then 1. And once converted to string I just remove the leftmost digit. Is this is enough for you?

I plan to use it also for the EB value to put in the coinbase string. Other than that I really don't know how to declare a function private outside of a class.

right, will fix

*rightmost

I did the same way BU and Classic did, just for the sake of compatibility.

Ok will do

and for what is worth I'm pretty sure BU permit also EB to be lower than 1MB, dunno about classic

I think there should be a test of formatting for blocksize == 0 and for blocksize ~ 0.1MB or so, to make sure that the above operations with .at(...) and so forth on the string also work for these corner cases.

In ABC EB can't be less than 1,000,000, see rpc/abc.cpp

Fair point. I was simply worried that at some point in the future, the above formatting function is called with bogus values from somewhere and might fail hard (out-of-bounds string access exception or such).

I suppose we could add a check on the passed EB value, but if a EB lower than 1MB percolate down here means we failed bad at higher levels. let see what @deadalnix have to say about it.

Config as first argument.

passed as arguent

Small and big as well actually.

will do