Page MenuHomePhabricator
Differential D2163

[Part 2 of 4] [qa] De-globalize port seeding
AbandonedPublic
Actions

Authored by schancel on Nov 30 2018, 21:41.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

This commit makes initialize_datadir take it's port parameters
instead of inferring them from global state by itself.

This will enable removing the global p2p_port and rpc_port
functions in our next commit.

Depends on D2159

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Event Timeline

schancel created this revision.Nov 30 2018, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 21:41
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a subscriber: teamcity.Nov 30 2018, 21:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a child revision: D2164: [Part 4 of 4] [qa] De-globalize port seeding.Nov 30 2018, 21:47
schancel retitled this revision from [Part 1 of 3] [qa] De-globalize port seeding to [Part 2 of 3] [qa] De-globalize port seeding.Nov 30 2018, 21:48
teamcity added a comment.Nov 30 2018, 21:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4204: Diff 6209!Nov 30 2018, 21:52
schancel updated this revision to Diff 6216.Nov 30 2018, 22:58

Rebase and fix extraneous changes

schancel added a child revision: D2165: [Part 3 of 4] [qa] De-globalize port seeding.Nov 30 2018, 22:59
teamcity added a comment.Nov 30 2018, 23:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel removed a child revision: D2164: [Part 4 of 4] [qa] De-globalize port seeding.Nov 30 2018, 23:01
schancel retitled this revision from [Part 2 of 3] [qa] De-globalize port seeding to [Part 2 of 4] [qa] De-globalize port seeding.
teamcity added a comment.Nov 30 2018, 23:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4211: Diff 6216!Nov 30 2018, 23:08
schancel updated this revision to Diff 6226.Dec 1 2018, 21:58

Rebase

teamcity added a comment.Dec 1 2018, 22:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 1 2018, 22:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4221: Diff 6226!Dec 1 2018, 22:14
jasonbcox accepted this revision.Jan 2 2019, 18:44
This revision is now accepted and ready to land.Jan 2 2019, 18:44
jasonbcox requested changes to this revision.Jan 2 2019, 18:45

Noticed harbormaster isn't passing.

This revision now requires changes to proceed.Jan 2 2019, 18:45
schancel abandoned this revision.Mar 17 2019, 04:32

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
9 lines
6 lines

Diff 6209

View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...