Page MenuHomePhabricator
Differential D2190

Update doc/benchmarking.md
ClosedPublic
Actions

Authored by Mengerian on Dec 13 2018, 17:21.

Details

Reviewers
Fabien
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T59: Change branding and documentation from Bitcoin Core to Bitcoin ABC
Commits
rSTAGING5075f4b11b98: Update doc/benchmarking.md
rABC5075f4b11b98: Update doc/benchmarking.md
Summary

The documentation seemed out-of-date. Updated based on the output from
running the command: src/bench/bench_bitcoin

Test Plan

run src/bench/bench_bitcoin and inspect output. check that documentation
matched test output.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
T59
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4310
Build 6685: Bitcoin ABC Buildbot (legacy)
Build 6684: arc lint + arc unit

Event Timeline

Mengerian created this revision.Dec 13 2018, 17:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2018, 17:21
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 13 2018, 17:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian added a comment.Dec 13 2018, 17:24

I'm a bit unsure about the list of what's included, and what is still needed.

@Fabien, @jasonbcox Could you guys help double-check the list for me, to see if I missed something or mis-interpreted the benchmark output?

teamcity added a comment.Dec 13 2018, 17:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4310: Diff 6338.Dec 13 2018, 17:31
Fabien added inline comments.Dec 15 2018, 16:29
doc/benchmarking.md
29

From my understanding the actual mempool benchmark does not cover everything that could be benchmarked, thus the Memory pool mention can be left in place. @jasonbcox can you confirm this ?

deadalnix accepted this revision.Dec 20 2018, 13:04
This revision is now accepted and ready to land.Dec 20 2018, 13:04
Mengerian updated this revision to Diff 6378.Dec 20 2018, 19:21

Add Memory pool back into "needed" list as per Fabien comment

teamcity added a comment.Dec 20 2018, 19:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 20 2018, 19:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4334: Diff 6378.Dec 20 2018, 19:31
Closed by commit rABC5075f4b11b98: Update doc/benchmarking.md (authored by Mengerian). · Explain WhyDec 20 2018, 19:54
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
52 lines

Diff 6338

View Options

doc/benchmarking.md

Loading...