Page MenuHomePhabricator
Differential D2220

Fix clang warnings
ClosedPublic
Actions

Authored by Fabien on Dec 22 2018, 22:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING23b1fc5ca89a: Fix clang warnings
rABC23b1fc5ca89a: Fix clang warnings
Summary

There is one remaining warning in leveldb.
The unused -pthread warning is removed by D2219.
This diff fix all the other warnings.

Test Plan

Build with clang and check there is no warning (exceptions are
mentionned above)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clang_warnings
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4359
Build 6783: Bitcoin ABC Buildbot (legacy)
Build 6782: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 22 2018, 22:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2018, 22:30
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 22 2018, 22:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 22 2018, 22:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4359: Diff 6416!Dec 22 2018, 22:41
teamcity added a comment.Dec 23 2018, 13:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 23 2018, 13:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 23 2018, 13:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Dec 23 2018, 13:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4359: Diff 6416.Dec 23 2018, 13:55
deadalnix accepted this revision.Dec 23 2018, 14:45
This revision is now accepted and ready to land.Dec 23 2018, 14:45
Closed by commit rABC23b1fc5ca89a: Fix clang warnings (authored by Fabien). · Explain WhyDec 23 2018, 15:36
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
3 lines
qt/
2 lines

Diff 6416

View Options

src/avalanche.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/qt/splashscreen.h

Loading...