Page MenuHomePhabricator
Differential D2260

Move scheduler/threadGroup into common-init instead of per-app
ClosedPublic
Actions

Authored by jasonbcox on Jan 7 2019, 06:46.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa9d157640140: Move scheduler/threadGroup into common-init instead of per-app
rABCa9d157640140: Move scheduler/threadGroup into common-init instead of per-app
Summary

This resolves #12229 which pointed out a shutdown deadlock due to
scheduler/checkqueue having been shut down while network message
processing is still running.

Backport of Core PR 12266
T507

Test Plan

The bug this fixes is difficult to reproduce, so I did the following to verify that nothing is obviously broken:
test_runner.py passes
bitcoin-qt validating that it starts, can be used normally, and shuts down without issue.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12266
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4431
Build 6927: Bitcoin ABC Buildbot (legacy)
Build 6926: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 7 2019, 06:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2019, 06:46
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 7 2019, 06:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 7 2019, 06:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4431: Diff 6533.Jan 7 2019, 06:57
deadalnix accepted this revision.Jan 7 2019, 23:18
This revision is now accepted and ready to land.Jan 7 2019, 23:18
Closed by commit rABCa9d157640140: Move scheduler/threadGroup into common-init instead of per-app (authored by Matt Corallo <git@bluematt.me>, committed by jasonbcox). · Explain WhyJan 8 2019, 19:19
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D3050: Fix more init bugs..May 15 2019, 11:15
Fabien mentioned this in rABCc7f22f815621: Fix more init bugs..May 16 2019, 07:20
nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30
Fabien mentioned this in rSTAGINGc7f22f815621: Fix more init bugs..Sep 18 2019, 23:33

Revision Contents
Changeset List

PathSize
src/
22 lines
5 lines
20 lines
qt/
10 lines

Diff 6533

View Options

src/bitcoind.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...