Do not make it trivial for inbound peers to generate log entries
ClosedPublic
Actions

Authored by dagurval on Jan 16 2019, 08:46.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf6c8a4ef792e: Do not make it trivial for inbound peers to generate log entries
rABCf6c8a4ef792e: Do not make it trivial for inbound peers to generate log entries

Summary

https://github.com/bitcoin/bitcoin/pull/11583

We should generally avoid writing to debug.log unconditionally for
inbound peers which misbehave (the peer being about to be banned
being an exception, since they cannot do this twice).

To avoid removing logs for outbound peers, a new log is added to
notify users when a new outbound peer is connected which mimics
the version print.

This is a backport of Core PR11583

Test Plan

Diff Detail

Repository

rABC Bitcoin ABC

Branch

logfix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4567
Build 7197: Bitcoin ABC Buildbot (legacy)
Build 7196: arc lint + arc unit

Event Timeline

dagurval created this revision.Jan 16 2019, 08:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2019, 08:46

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

dagurval retitled this revision from Do not make it trivial for inbound peers to generate log entries https://github.com/bitcoin/bitcoin/pull/11583 to Do not make it trivial for inbound peers to generate log entries.Jan 16 2019, 08:47

dagurval edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4540: Diff 6688.Jan 16 2019, 08:56

Thanks, it is a great find.

Please also backport the added comment. In our codebase, it would be in logging.h instead of util.h .

This revision now requires changes to proceed.Jan 17 2019, 02:11

deadalnix edited the summary of this revision. (Show Details)Jan 17 2019, 02:12

Port over missing comment

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4561: Diff 6710.Jan 17 2019, 11:46