Page MenuHomePhabricator
Differential D2343

Update CONTRIBUTING.md to clang-7
ClosedPublic
Actions

Authored by Mengerian on Jan 19 2019, 04:38.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING0f768b4acd62: Update CONTRIBUTING.md to clang-7
rABC0f768b4acd62: Update CONTRIBUTING.md to clang-7
Summary

Also add apt package link

Test Plan

I used the apt.llvm.org source to install clang-7 in Ubuntu, and it worked.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clang7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4580
Build 7223: Bitcoin ABC Buildbot (legacy)
Build 7222: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jan 19 2019, 04:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2019, 04:38
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 19 2019, 04:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4578: Diff 6742.Jan 19 2019, 04:48
teamcity added a comment.Jan 19 2019, 04:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a subscriber: markblundeberg.Jan 19 2019, 05:57

What about this thing I had to run? update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-7 100 -- was that not needed when you grabbed it from apt.llvm.org?

deadalnix accepted this revision.Jan 19 2019, 13:32
This revision is now accepted and ready to land.Jan 19 2019, 13:32
deadalnix added a comment.Jan 19 2019, 13:33

@markblundeberg We should try to update the system's default on people's computers, IMO. It doesn't need to be the default anyways, it needs to be installed.

Mengerian updated this revision to Diff 6744.Jan 19 2019, 14:33

Make link https

teamcity added a comment.Jan 19 2019, 14:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 19 2019, 14:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4580: Diff 6744.Jan 19 2019, 14:43
Mengerian added a comment.Jan 19 2019, 14:51

@markblundeberg Yeah, I think that's a bit too specific, as it assumes what system the person is running, and people might have all kinds of different configurations. We don't want to get into system configuration management in these docs.

This at least points them in the right direction.

Closed by commit rABC0f768b4acd62: Update CONTRIBUTING.md to clang-7 (authored by Mengerian). · Explain WhyJan 19 2019, 15:38
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
4 lines

Diff 6744

View Options

CONTRIBUTING.md

Loading...