Page MenuHomePhabricator
Differential D2366

[tests] fix flake8 warnings in node_network_limited.py
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 16:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING821487e196c5: [tests] fix flake8 warnings in node_network_limited.py
rABC821487e196c5: [tests] fix flake8 warnings in node_network_limited.py
Summary

This cleans up the comments and make the variables/functions conform to
python snake_case.

Partial backport of core PR11867 (commit 1285312)

Depends on D2363

Test Plan
./test/functional/test_runner.py node_network_limited.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11867_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4611
Build 7285: Bitcoin ABC Buildbot (legacy)
Build 7284: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 21 2019, 16:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 16:08
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 21 2019, 16:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 21 2019, 16:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4611: Diff 6781.Jan 21 2019, 16:17
Fabien added a child revision: D2367: [tests] define NODE_NETWORK_LIMITED in test framework.Jan 21 2019, 16:18
deadalnix accepted this revision.Jan 21 2019, 17:30
deadalnix added inline comments.
test/functional/node_network_limited.py
53

NODE_WITNESS is incorrect here. Obviously not related to this patch, so it can fixed somewhere else.

This revision is now accepted and ready to land.Jan 21 2019, 17:30
Closed by commit rABC821487e196c5: [tests] fix flake8 warnings in node_network_limited.py (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 18:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING821487e196c5: [tests] fix flake8 warnings in node_network_limited.py.Sep 18 2019, 22:01

Revision Contents
Changeset List

PathSize
test/
functional/
33 lines

Diff 6781

View Options

test/functional/node_network_limited.py

Loading...