add SCRIPT_ENABLE_SCHNORR flag
ClosedPublic
Actions

Authored by markblundeberg on Jan 29 2019, 02:56.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Maniphest Tasks

T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG

Commits

rSTAGING8e3e7df4ccb7: add SCRIPT_ENABLE_SCHNORR flag
rABC8e3e7df4ccb7: add SCRIPT_ENABLE_SCHNORR flag

Summary

This merely adds the flag -- no change in behaviour yet.
Numerous tests are duplicated in script_tests to make sure that nothing
weird happens when the flag is merely activated.

Test Plan

run test_bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add_schnorr_flag

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4731
Build 7525: Bitcoin ABC Buildbot (legacy)
Build 7524: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 29 2019, 02:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2019, 02:56

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

markblundeberg added a task: T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.Jan 29 2019, 02:56

This comment was removed by markblundeberg.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

oops, forgot to include a commit

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

I am now getting a warning when compiling script_tests.cpp, I guess because that script builder is too long:

../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:433:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {

Not sure how to fix this. :-/

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4731: Diff 6978.Jan 29 2019, 03:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4732: Diff 6979.Jan 29 2019, 03:16

@markblundeberg Did you activate the undefined sanitizer (ubsan) ? This would explain your warning, this is a tool limitation.

In D2430#55413, @Fabien wrote:

@markblundeberg Did you activate the undefined sanitizer (ubsan) ? This would explain your warning, this is a tool limitation.

I didn't do anything out of the ordinary, though I do have libubsan0:amd64 installed.

Regarding the warning: https://github.com/bitcoin/bitcoin/issues/10030 Looks like Core didn't care about the issue much either.

jasonbcox accepted this revision.Jan 29 2019, 23:13

This revision is now accepted and ready to land.Jan 29 2019, 23:13

In D2430#55534, @jasonbcox wrote:

Regarding the warning: https://github.com/bitcoin/bitcoin/issues/10030 Looks like Core didn't care about the issue much either.

Mmmm that makes sense. Good to know it's as benign as it sounds like.

Closed by commit rABC8e3e7df4ccb7: add SCRIPT_ENABLE_SCHNORR flag (authored by Mark Lundeberg). · Explain WhyJan 30 2019, 20:11

This revision was automatically updated to reflect the committed changes.

markblundeberg mentioned this in D3253: Remove Schnorr activation.Jun 7 2019, 03:14

markblundeberg mentioned this in D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.Jun 14 2019, 04:25

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC7cfc38d37a8f: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.Jun 27 2019, 18:08

Mark Lundeberg added a commit: rSTAGING8e3e7df4ccb7: add SCRIPT_ENABLE_SCHNORR flag.Sep 18 2019, 22:10

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING7cfc38d37a8f: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.Sep 19 2019, 00:38