Page MenuHomePhabricator
Differential D2434

ArgsManager: support config file sections
ClosedPublic
Actions

Authored by Fabien on Jan 29 2019, 14:28.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf3a3fd103236: ArgsManager: support config file sections
rABCf3a3fd103236: ArgsManager: support config file sections
Summary

This adds support for network sections in the configuration file.
There is no special case management yet.

Partial backport of core PR11862
Commits 95eb66d, 30f9407 and 8a9817d

Depends on D2433

Test Plan
make check
./test/functional/test_runner.py feature_config_args

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11862_part3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4738
Build 7539: Bitcoin ABC Buildbot (legacy)
Build 7538: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 29 2019, 14:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2019, 14:28
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 29 2019, 14:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 15:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4738: Diff 6985.Jan 29 2019, 15:04
Fabien added a child revision: D2435: Limit some options to only apply on mainnet when in default section.Jan 29 2019, 15:08
Fabien mentioned this in D2432: ArgsManager: keep command line and config file arguments separate.Jan 29 2019, 19:01
jasonbcox accepted this revision.Jan 29 2019, 19:13
This revision is now accepted and ready to land.Jan 29 2019, 19:13
Fabien updated this revision to Diff 6995.Jan 29 2019, 19:30

Rebase

teamcity added a comment.Jan 29 2019, 19:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4746: Diff 6995.Jan 29 2019, 19:45
teamcity added a comment.Jan 29 2019, 19:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCf3a3fd103236: ArgsManager: support config file sections (authored by Anthony Towns <aj@erisian.com.au>, committed by Fabien). · Explain WhyFeb 5 2019, 07:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGf3a3fd103236: ArgsManager: support config file sections.Sep 18 2019, 22:16

Revision Contents
Changeset List

PathSize
doc/
13 lines
src/
1 line
test/
70 lines
7 lines
43 lines
test/
functional/
7 lines
test_framework/
1 line

Diff 6985

View Options

doc/release-notes.md

Loading...
View Options

src/chainparamsbase.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util.h

Loading...
View Options

src/util.cpp

Loading...
View Options

test/functional/feature_config_args.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...