This returns main chain to ForkID of 0 after the May 2019 upgrade and implements automatic replay protection for the Nov 2019 upgrade.
For reference see last bump in D1612
(original author of diff: dagurval)
Details
Details
- Reviewers
deadalnix Mengerian dagurval - Group Reviewers
Restricted Project - Commits
- rSTAGING31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade
rABC31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade
Replay protection is covered by unit tests, however it is very important to manually double check that the timestamp for activation is set correctly.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D2376
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4960 Build 7983: Bitcoin ABC Buildbot (legacy) Build 7982: arc lint + arc unit
Event Timeline
Comment Actions
Marking as request change, even though there is really no change to be made, just to clear the review queue.
Comment Actions
I double-checked the timestamps and everything looks good to me.
Will need to be rebased and release notes portion resolved if pushed to the next release.
Comment Actions
Looks like this is ready to go -- just return it for review from the comment Action menu.
Comment Actions
Yeah, @dagurval you just need to rebase for the release notes, and then it should be ready to land
EDIT: Although in theory it may be best to land this Diff last, after all the other "activation" Diffs, so that no build will ever conflict with the Upgrade release without replay protection.