blockfilter: add block filters
ClosedPublic
Actions

Authored by markblundeberg on Apr 23 2019, 03:18.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Maniphest Tasks

T589: BIP157 & BIP158 backports

Commits

rSTAGINGf1cf81504278: blockfilter: add block filters
rABCf1cf81504278: blockfilter: add block filters

Summary

Part of BIP158, this is made from last backports from PR 12254:
97b64d67d blockfilter: Unit test against BIP 158 test vectors.
a4afb9cad blockfilter: Additional helper methods to compute hash and header.
cd09c7925 blockfilter: Serialization methods on BlockFilter.
c1855f605 blockfilter: Construction of basic block filters.

plus a fix from PR 14073:
f05599557 blockfilter: Omit empty scripts from filter contents.

Two test cases containing segwit coinbase transactions were removed from
blockfilter_tests.json due to their failing to parse, and inapplicability.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bip158d

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5604
Build 9270: Bitcoin ABC Buildbot (legacy)
Build 9269: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Apr 23 2019, 03:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 03:18

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T589: BIP157 & BIP158 backports.Apr 23 2019, 03:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5576: Diff 8235.Apr 23 2019, 03:32

markblundeberg added a child revision: D2872: blockfilter: Refactor and add tests for BlockFilter construction.Apr 24 2019, 05:18

Fabien requested changes to this revision.Apr 25 2019, 08:57

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/blockfilter.cpp
7 ↗	(On Diff #8235)	Is this a rebase issue ? It already here in D2803
210 ↗	(On Diff #8235)	braces
218 ↗	(On Diff #8235)	dito
src/test/blockfilter_tests.cpp
13 ↗	(On Diff #8235)	Could you reorder these to match the other tests: move blockfilter.h first on its own line, move test/*.h after the other project includes move univalue.h after boost includes
71 ↗	(On Diff #8235)	Move comment above
110 ↗	(On Diff #8235)	`unsigned int` => `size_t`
121 ↗	(On Diff #8235)	dito
133 ↗	(On Diff #8235)	dito