Make functions in rpc/blockchain.cpp static.
ClosedPublic
Actions

Authored by jasonbcox on May 6 2019, 23:55.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING62cdb28b5acf: Make functions in rpc/blockchain.cpp static.
rABC62cdb28b5acf: Make functions in rpc/blockchain.cpp static.

Summary

Partial backport of Core PR 13163
https://github.com/bitcoin/bitcoin/pull/13163/files#diff-a0c8f511d90e83aa9b5857e819ced344
Only partially completed since the original PR is massive.
Progress towards T644

Depends on D2951, D2946

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13163

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5710
Build 9482: Bitcoin ABC Buildbot (legacy)
Build 9481: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 6 2019, 23:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2019, 23:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5710: Diff 8438.May 7 2019, 00:11

jasonbcox added a child revision: D2955: Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime locking assertions.May 7 2019, 00:16

Fabien accepted this revision.May 7 2019, 10:10

This revision is now accepted and ready to land.May 7 2019, 10:10

jasonbcox mentioned this in T644: Backport Core PR 13163.May 8 2019, 21:35

jasonbcox edited the summary of this revision. (Show Details)

Closed by commit rABC62cdb28b5acf: Make functions in rpc/blockchain.cpp static. (authored by jasonbcox). · Explain WhyMay 8 2019, 21:38

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30

jasonbcox added a commit: rSTAGING62cdb28b5acf: Make functions in rpc/blockchain.cpp static..Sep 18 2019, 23:23

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

80 lines

Diff 8438

View Options

Make functions in rpc/blockchain.cpp static.ClosedPublicActions