Page MenuHomePhabricator
Differential D3034

[CMAKE] Disable OpenGL in Qt static build for OSX
ClosedPublic
Actions

Authored by Fabien on May 13 2019, 10:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3c8b87cf3dda: [CMAKE] Disable OpenGL in Qt static build for OSX
rABC3c8b87cf3dda: [CMAKE] Disable OpenGL in Qt static build for OSX
Summary

A bug in the CMake files distributed by Qt prevent building with static
OpenGL on OSX (hard linked dependency to the framework in the Qt5Gui
dependencies). To workaround the issue, the static Qt is built without
the OpenGL support.

This fixes the bitcoin-qt cross build for OSX.

Depends on D3017 and D3033 (for the test plan).

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja

Run the generated src/qt/bitcoin-qt on OSX >= 10.8 (tested on OSX Sierra
10.12.6).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_osx_fix_qt_opengl
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5830
Build 9722: Bitcoin ABC Buildbot (legacy)
Build 9721: arc lint + arc unit

Event Timeline

Fabien created this revision.May 13 2019, 10:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 10:23
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 13 2019, 10:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5830: Diff 8630.May 13 2019, 10:38
teamcity added a comment.May 13 2019, 10:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 14 2019, 13:22
This revision is now accepted and ready to land.May 14 2019, 13:22
Fabien mentioned this in D3018: [CMAKE] Fix CMake cross build for OSX.May 25 2019, 07:15
Closed by commit rABC3c8b87cf3dda: [CMAKE] Disable OpenGL in Qt static build for OSX (authored by Fabien). · Explain WhyMay 25 2019, 07:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3c8b87cf3dda: [CMAKE] Disable OpenGL in Qt static build for OSX.
Fabien added a commit: rSTAGING3c8b87cf3dda: [CMAKE] Disable OpenGL in Qt static build for OSX.Sep 18 2019, 23:45
Fabien mentioned this in D5666: build: pass -dead_strip_dylibs to ld on macOS.Apr 3 2020, 09:37
Fabien mentioned this in rABCf481021ebe93: build: pass -dead_strip_dylibs to ld on macOS.Apr 3 2020, 15:52
Fabien mentioned this in rSTAGINGf481021ebe93: build: pass -dead_strip_dylibs to ld on macOS.Apr 7 2020, 21:50

Revision Contents
Changeset List

PathSize
depends/
packages/
4 lines

Diff 8630

View Options

depends/packages/qt.mk

Loading...