This is a partial backport of Core PR11116 : https://github.com/bitcoin/bitcoin/pull/11116/commits/d7afe2d1577eb3f6775301c81b94a191e0db99d9
Details
Details
- Reviewers
markblundeberg - Group Reviewers
Restricted Project - Commits
- rSTAGINGcf54664b876c: [script] Unit tests for script/standard functions
rABCcf54664b876c: [script] Unit tests for script/standard functions
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- stdtests
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5988 Build 10035: Bitcoin ABC Buildbot (legacy) Build 10034: arc lint + arc unit
Event Timeline
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 | This is good, it would be awful it we had to start supporting bech32 recoveries as well! :D | |
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 | (However maybe these should be moved out from the script_standard_Solver_success test) | |
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 | Unless you volunteer to maintain it, I don't think it's a good idea. | |
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 | OK, can we add a comment or something? Just looks weird having failure tests in success section. | |
| 113 | This is not in original PR nor does Core have it in current file. But it does appear to make sense here. | |
| 227 | An erroneous test per Wuille's comment -- https://github.com/bitcoin/bitcoin/pull/11116#discussion_r140642842 | |
| 303 | also erroneous P2WSH... | |