Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Project

Maniphest Tasks

T630: Backport PR 13243 "Make reusable base class for auxiliary indices"

Commits

rSTAGINGe06f70b4713e: index: Move index DBs into index/ directory.
rABCe06f70b4713e: index: Move index DBs into index/ directory.

Summary

backports last two commits from PR13243:
ec3073a27 index: Move index DBs into index/ directory.
89eddcd36 index: Remove TxIndexDB from public interface of TxIndex.
https://github.com/bitcoin/bitcoin/compare/89eddcd36~1..ec3073a27

(these diffs are co-dependent and need to be brought in as one)

Depends on D2933 D2934 D2937 , and D2932

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

baseidxF

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6030
Build 10119: Bitcoin ABC Buildbot (legacy)
Build 10118: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 23:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 23:45

Herald added a reviewer: deadalnix. · View Herald Transcript

markblundeberg added a task: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".May 5 2019, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5691: Diff 8406.May 6 2019, 00:00

markblundeberg added reviewers: Fabien, jasonbcox.May 23 2019, 00:57

markblundeberg planned changes to this revision.May 23 2019, 23:08

note to self: needs to be updated appropriately if D3115 is wanted.

note to self: remove unsigned chars!

rebased; de-charred

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)May 27 2019, 02:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6001: Diff 8902.May 27 2019, 02:31

markblundeberg added inline comments.May 27 2019, 03:11

src/index/txindex.cpp
137 ↗	(On Diff #8902)	note -- added in D3115; I have moved it up a line here to make debug.log cleaner (doesn't appear between [0%] and [10]% logs)

deadalnix requested changes to this revision.May 27 2019, 21:26

deadalnix added inline comments.

src/index/base.cpp
5 ↗	(On Diff #8902)	Remove.
src/index/txindex.h
8 ↗	(On Diff #8902)	Remove

This revision now requires changes to proceed.May 27 2019, 21:26

remove txindex.h dependency on chain.h

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added inline comments.May 28 2019, 02:33

src/index/base.cpp
5 ↗	(On Diff #8902)	this one is needed for `CBlockIndex` definition; stuff like `chain_tip->nHeight` occurs in the file.
src/index/txindex.h
8 ↗	(On Diff #8902)	You're right; this one is happy just inheriting a forward declaration of `CBlockIndex` from index/base.h.