Page MenuHomePhabricator

Reject non replay protected transactions after the fork.
ClosedPublic

Authored by deadalnix on Jul 24 2017, 00:21.

Details

Summary

This ensure that the HF activates STRICTENCODING (just standard right now, not consensus) and it'll reject any transaction not using SIGHASH_FORKID after the fork.
To make sure we get a clean mempool, the mempool is cleared when we connect a block that activate the fork.

Numerous places have to check for transactionw ith and without the forkid flag. This is abit wonky, but, hopefully, we'll be able to cleanup that mess after Aug, 1 and that'll come very soon.

Test Plan

Updated related tests.

make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nonforkidillegal
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 575
Build 575: arc lint + arc unit