Page MenuHomePhabricator
Differential D3364

wallet: Make fee settings non-static members
ClosedPublic
Actions

Authored by deadalnix on Jun 18 2019, 23:37.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGafc4447ef4ef: wallet: Make fee settings non-static members
rABCafc4447ef4ef: wallet: Make fee settings non-static members
Summary

This isa backport of Core PR12909

Test Plan
make check
test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12909
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6396
Build 10839: Bitcoin ABC Buildbot (legacy)
Build 10838: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 18 2019, 23:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 18 2019, 23:37
teamcity added a comment.Jun 18 2019, 23:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 18 2019, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6396: Diff 9526.Jun 18 2019, 23:45
Fabien requested changes to this revision.Jun 19 2019, 06:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcwallet.cpp
3100

Remove

This revision now requires changes to proceed.Jun 19 2019, 06:34
deadalnix updated this revision to Diff 9534.Jun 19 2019, 12:49

Rebase

teamcity added a comment.Jun 19 2019, 12:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6402: Diff 9534.Jun 19 2019, 12:56
teamcity added a comment.Jun 19 2019, 12:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Jun 20 2019, 20:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/interfaces/wallet.h
27 ↗(On Diff #9534)

This looks like it's unused.

src/wallet/fees.cpp
54 ↗(On Diff #9534)

Missing backport to the comment

This revision now requires changes to proceed.Jun 20 2019, 20:21
deadalnix updated this revision to Diff 9555.Jun 21 2019, 00:12

Rebase and remove redundant forward declaration

teamcity added a comment.Jun 21 2019, 00:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2019, 00:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6417: Diff 9555.Jun 21 2019, 00:20
deadalnix added a child revision: D3377: Fix Clang Static Analyzer warnings.Jun 21 2019, 01:28
deadalnix added a child revision: D3378: Actually disable BnB when there are preset inputs.Jun 21 2019, 02:03
jasonbcox accepted this revision.Jun 21 2019, 21:41
Fabien added inline comments.Jun 24 2019, 07:13
src/wallet/rpcwallet.cpp
3100 ↗(On Diff #9555)

This comment is removed in the original PR, did you let it on purpose ?

deadalnix updated this revision to Diff 9613.Jun 24 2019, 15:35

Remove comment

teamcity added a comment.Jun 24 2019, 15:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Jun 24 2019, 15:45
This revision is now accepted and ready to land.Jun 24 2019, 15:45
This revision was landed with ongoing or failed builds.Jun 24 2019, 15:48
Closed by commit rABCafc4447ef4ef: wallet: Make fee settings non-static members (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCafc4447ef4ef: wallet: Make fee settings non-static members.
deadalnix added a commit: rSTAGINGafc4447ef4ef: wallet: Make fee settings non-static members.Sep 19 2019, 00:28
majcosta mentioned this in T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members.Jul 28 2020, 08:32

Revision Contents
Changeset List

PathSize
src/
interfaces/
8 lines
10 lines
8 lines
9 lines
qt/
2 lines
11 lines
wallet/
2 lines
18 lines
25 lines
62 lines
8 lines
22 lines
96 lines
test/
functional/
7 lines

Diff 9526

View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/wallet/coincontrol.h

Loading...
View Options

src/wallet/fees.h

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...