Page MenuHomePhabricator

wallet: Make fee settings non-static members
ClosedPublic

Authored by deadalnix on Jun 18 2019, 23:37.

Details

Summary

This isa backport of Core PR12909

Test Plan
make check
test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12909
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6459
Build 10965: Bitcoin ABC Buildbot (legacy)
Build 10964: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jun 19 2019, 06:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcwallet.cpp
3100 ↗(On Diff #9526)

Remove

This revision now requires changes to proceed.Jun 19 2019, 06:34
jasonbcox requested changes to this revision.Jun 20 2019, 20:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/interfaces/wallet.h
27 ↗(On Diff #9534)

This looks like it's unused.

src/wallet/fees.cpp
54 ↗(On Diff #9534)

Missing backport to the comment

This revision now requires changes to proceed.Jun 20 2019, 20:21

Rebase and remove redundant forward declaration

src/wallet/rpcwallet.cpp
3100 ↗(On Diff #9555)

This comment is removed in the original PR, did you let it on purpose ?

This revision is now accepted and ready to land.Jun 24 2019, 15:45
This revision was landed with ongoing or failed builds.Jun 24 2019, 15:48
This revision was automatically updated to reflect the committed changes.