Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jul 14 2017

CCulianu added a comment to D331: Attempt to fix segfault bug.

You don't have to accept this patch .. I basically wanted it here just in case you guys decide to get paranoid and catch every time CNodeState might be null.

Jul 14 2017, 22:18
CCulianu added a reviewer for D331: Attempt to fix segfault bug: deadalnix.
Jul 14 2017, 22:14
Herald added a reviewer for D331: Attempt to fix segfault bug: Restricted Project.
Jul 14 2017, 22:04
CCulianu added a comment to D324: Fix segfault when node no longer connected.

Question: when is that lNodesAnnouncingHeaderAndIDs private list cleaned up if a node should disconnect early. I don't see it being cleaned up in FinalizeNode()...

Jul 14 2017, 12:22
CCulianu added a comment to D324: Fix segfault when node no longer connected.

OK, aside from my bitching about the use of NULL.. the real thing is here the end result will be the same with these asserts, namely the program will EXIT (effectively crash).

Jul 14 2017, 08:57
CCulianu added a comment to D324: Fix segfault when node no longer connected.

Man I feel like toxic LukeJr lately. All I can come up with are critical comments. Sorry ahead of time.

Jul 14 2017, 08:40

Jul 4 2017

CCulianu committed rABCa78d5cbd3a89: Addresses hang issue seen in T28 by freetrader -- properly register Config type… (authored by CCulianu).
Addresses hang issue seen in T28 by freetrader -- properly register Config type…
Jul 4 2017, 18:28
CCulianu closed D292: Addresses hang issue seen in T28 by freetrader -- properly register Config type with Qt so it may be used in signals/slots by committing rABCa78d5cbd3a89: Addresses hang issue seen in T28 by freetrader -- properly register Config type….
Jul 4 2017, 18:28
CCulianu added a comment to D292: Addresses hang issue seen in T28 by freetrader -- properly register Config type with Qt so it may be used in signals/slots.

Ok sounds good guys. Let me know if I should land it.

Jul 4 2017, 12:50

Jul 3 2017

CCulianu added a comment to D291: Use raw string comparison instead of std::regex , as it is clearly not mature..

Ok -- apologies but I'm a phabricator nub. How do I find out what systems it broke on? Any build logs or anything?

Jul 3 2017, 11:35
Herald added 1 blocking reviewer(s) for D292: Addresses hang issue seen in T28 by freetrader -- properly register Config type with Qt so it may be used in signals/slots: Restricted Project.
Jul 3 2017, 11:31
CCulianu committed rABC79943feda175: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards… (authored by CCulianu).
Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards…
Jul 3 2017, 09:19
CCulianu closed D290: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations. by committing rABC79943feda175: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards….
Jul 3 2017, 09:19

Jul 2 2017

CCulianu updated the test plan for D290: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations..
Jul 2 2017, 10:30
Herald added 1 blocking reviewer(s) for D290: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations.: Restricted Project.
Jul 2 2017, 10:29
First
Prev