Commandeering this to put in the minor fixes required - the GUI stuff can be submitted separately later as pointed out
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 28 2017
Jul 28 2017
All fine (tested)
Jul 27 2017
Jul 27 2017
All good
freetrader committed rABC4fd05d5377d4: Update various debian packaging files (authored by freetrader).
Update various debian packaging files
freetrader accepted D385: Do not increase the banscore of node forwarding transactions that are not valid yet..
LGTM
freetrader added inline comments to D385: Do not increase the banscore of node forwarding transactions that are not valid yet..
freetrader requested changes to D381: Removed using namespace std and replaced with std:: throughout file.
@AtlasShrugging : I reviewed and ran the tests over your code, it's good, but please amend the Summary and Test Plan based on our discussion above, then I can accept...
Test plan for such error changes needs to include system test suite.
freetrader committed rABC3a2aefb95b72: Fix abc-p2p-activation expected error code (authored by freetrader).
Fix abc-p2p-activation expected error code
Herald added 1 blocking reviewer(s) for D383: Fix abc-p2p-activation expected error code: Restricted Project.
freetrader added a comment to D381: Removed using namespace std and replaced with std:: throughout file.
@AtlasShrugging re: your Test Plan question:
Jul 26 2017
Jul 26 2017
Thanks for clarifying.
I would have liked to see some more info on how to obtain the legacy data that is referred to in the test plan, but the code changes here look alright to me now.
Looks good to me.
Jul 25 2017
Jul 25 2017
Good news on the testing front.
freetrader committed rABC5dba98f66588: Update comment about consensus rule nature of SCRIPT_VERIFY_STRICTENC (authored by freetrader).
Update comment about consensus rule nature of SCRIPT_VERIFY_STRICTENC
freetrader committed rABC5acb719389a9: Update of UAHF specification doc to align for release (authored by freetrader).
Update of UAHF specification doc to align for release
Add release notes for v0.14.5
freetrader closed D378: Add release notes for v0.14.5 by committing rABC788af4ffa36a: Add release notes for v0.14.5.
Herald added 1 blocking reviewer(s) for D377: Update of UAHF specification doc to align for release: Restricted Project.
freetrader updated the diff for D375: Update comment about consensus rule nature of SCRIPT_VERIFY_STRICTENC.
Updated to remove the comment as discussed
Herald added 1 blocking reviewer(s) for D375: Update comment about consensus rule nature of SCRIPT_VERIFY_STRICTENC: Restricted Project.
Accepting this, changes look ok but it's just easier to look for missed things once this is merged.
Didn't spot issues with this change.
I put this back in Review based on sickpig's comment and the need to still test building of the Debian packages.
Jul 24 2017
Jul 24 2017
freetrader added a comment to D372: Cleanup of dead mapBlockSource entries that aren't needed in FinalizeNode.
@CCulianu : any way to accelerate the leak for testing purposes?
To clarify the completely removed comment. Rest looks good to me.
Add further user-visible changes submitted by Github user ethernomad
Updated with further user-visible changes submitted via Github by 'ethernomad' in this partially overlapping PR:
Refer: https://github.com/Bitcoin-ABC/bitcoin-abc/pull/27
Jul 23 2017
Jul 23 2017
No point in keeping this around then.
Could you explain how validation.cpp:1460 ff. are not using the new template class?
Jul 22 2017
Jul 22 2017
Pending test case for CHashVerifier class
freetrader added a comment to D364: Update the undo operation so they return a success/error code rather than taking out parameter.
LGTM, just have a question about why return value is ignored in one place.
Herald added 1 blocking reviewer(s) for D367: Add output to validation_tests loop to prevent Travis timing out: Restricted Project.
Test plan requires some legacy data. Could you add note how to obtain such legacy data, so the test becomes reproducible.
Rest of code changes look good, but introducing a new class without a unit test?
Add NODE_BITCOIN_CASH service bit
Herald added 1 blocking reviewer(s) for D366: Add NODE_BITCOIN_CASH service bit: Restricted Project.
Jul 21 2017
Jul 21 2017
freetrader committed rABCee2f17b73188: Document the change in default value for DNS seed use (authored by freetrader).
Document the change in default value for DNS seed use
Herald added 1 blocking reviewer(s) for D361: Document the change in default value for DNS seed use: Restricted Project.
freetrader committed rABCa90257622070: Use forcednsseed by default prior to the fork (authored by freetrader).
Use forcednsseed by default prior to the fork
Update from review comment
Herald added 1 blocking reviewer(s) for D360: Use forcednsseed by default prior to the fork: Restricted Project.
Jul 20 2017
Jul 20 2017
freetrader committed rABCedfe4b0574a2: Align ABC spec docs with UAHF specs of 2017-07-16 (authored by freetrader).
Align ABC spec docs with UAHF specs of 2017-07-16
Herald added 1 blocking reviewer(s) for D354: Align ABC spec docs with UAHF specs of 2017-07-16: Restricted Project.
Tested ok
and it should be " adjustment" in the title.
Didn't notice any defects in review.
Regression tests were ok, save for a couple of tests which fail intermittently, but those failures seem unrelated to the change at hand.
Passed tests.
freetrader committed rABC67c6abad55d9: Align unit test names with their filenames (authored by freetrader).
Align unit test names with their filenames
Note about test plan random seed:
freetrader retitled D350: Align unit test names with their filenames from Align unit test names with their filenames. to Align unit test names with their filenames.
Herald added 1 blocking reviewer(s) for D350: Align unit test names with their filenames: Restricted Project.
freetrader added a comment to D348: Uncache UTXO on a per outpoint basis instead of a per transaction basis.
Reviewed, no objections, ran the extended tests and passed.
Jul 19 2017
Jul 19 2017
Herald added 1 blocking reviewer(s) for D347: Update various debian packaging files: Restricted Project.
Jul 18 2017
Jul 18 2017
In D332#5765, @Candunc wrote:Yes, I can add this information.
Jul 17 2017
Jul 17 2017
Update release notes for 0.14.3