Page MenuHomePhabricator
Feed Advanced Search

Feb 22 2022

kieran709 updated the diff for D11097: [Cashtab] Create TokenIcon Component.

Removed antd popover from SendToken.js per discussion with bytesofman.

Feb 22 2022, 20:20
kieran709 requested review of D11097: [Cashtab] Create TokenIcon Component.
Feb 22 2022, 18:00
kieran709 abandoned D10807: [Cashtab] Created TokenIcon component.

Local repo pushed files that have been deleted since the UI overhaul, abandoning and re-submitting.

Feb 22 2022, 17:29
kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

Rebased and corrected conflicts.

Feb 22 2022, 17:25
kieran709 requested review of D11096: [Cashtab] Do not open scanner on Send screen when value and address are prepopulated.
Feb 22 2022, 17:16

Feb 21 2022

kieran709 closed D11074: [Cashtab] Removed obsolete dev note from Token.js.
Feb 21 2022, 16:44
kieran709 committed rABCc215e5b6a203: [Cashtab] Removed obsolete dev note from Token.js (authored by kieran709).
[Cashtab] Removed obsolete dev note from Token.js
Feb 21 2022, 16:44
kieran709 updated the diff for D11065: [Cashtab] Tx Hisotry collapse.

responded to review feedback, rebased & updated snapshots

Feb 21 2022, 16:41

Feb 18 2022

kieran709 abandoned D10837: [Cashtab] Implement dark theme + toggle.
Feb 18 2022, 17:51
kieran709 requested review of D11074: [Cashtab] Removed obsolete dev note from Token.js.
Feb 18 2022, 15:26
kieran709 updated the diff for D11065: [Cashtab] Tx Hisotry collapse.

Responded to review feedback, rebased and updated snapshots.

Feb 18 2022, 15:20

Feb 16 2022

kieran709 updated the diff for D11065: [Cashtab] Tx Hisotry collapse.

updated snapshots

Feb 16 2022, 19:43
kieran709 requested review of D11065: [Cashtab] Tx Hisotry collapse.
Feb 16 2022, 19:42
kieran709 abandoned D10869: [Cashtab] Tx history dropdown.

Resubmitting due to UI overhaul.

Feb 16 2022, 19:26

Feb 15 2022

kieran709 abandoned D11057: [Docs] Update Create eToken screenshots.

Abandoning until UI update lands.

Feb 15 2022, 18:09
kieran709 requested review of D11057: [Docs] Update Create eToken screenshots.
Feb 15 2022, 17:24

Feb 14 2022

kieran709 closed D11050: [Cashtab] Remove extra space on eToken creation error msg.
Feb 14 2022, 17:34
kieran709 committed rABCfa04aae9f300: [Cashtab] Remove extra space on eToken creation error msg (authored by kieran709).
[Cashtab] Remove extra space on eToken creation error msg
Feb 14 2022, 17:34
kieran709 requested review of D11050: [Cashtab] Remove extra space on eToken creation error msg.
Feb 14 2022, 16:29
kieran709 closed D11038: [Cashtab] Add support for Swiss Franc.
Feb 14 2022, 16:13
kieran709 committed rABC5921ce974862: [Cashtab] Add support for Swiss Franc (authored by kieran709).
[Cashtab] Add support for Swiss Franc
Feb 14 2022, 16:13

Feb 11 2022

kieran709 updated the diff for D11038: [Cashtab] Add support for Swiss Franc.

Responding to review feedback.

Feb 11 2022, 22:05
kieran709 abandoned D10847: [Cashtab] Add css props to SwButtnCtn.

Abandoning to avoid conflict with T2183.

Feb 11 2022, 15:37
kieran709 updated the summary of D11038: [Cashtab] Add support for Swiss Franc.
Feb 11 2022, 00:02
kieran709 updated the summary of D11040: [Cashtab] Remove separate block explorers for token txs..
Feb 11 2022, 00:01
kieran709 requested review of D11040: [Cashtab] Remove separate block explorers for token txs..
Feb 11 2022, 00:00

Feb 10 2022

kieran709 requested review of D11038: [Cashtab] Add support for Swiss Franc.
Feb 10 2022, 18:34

Feb 8 2022

kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

Responding to review feedback

Feb 8 2022, 18:39
kieran709 updated the diff for D10869: [Cashtab] Tx history dropdown.

responding to review feedback, renamed button component so I could reuse it to have style consistency.

Feb 8 2022, 16:00

Jan 28 2022

kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

responding to review feedback, removed span that wrapped TokenIconComponent in SendToken component.

Jan 28 2022, 16:41
kieran709 updated the diff for D10869: [Cashtab] Tx history dropdown.

Responding to review feedback, moved the collapse component out of TxHistory and into the Tx component. Moved pertinent styling out of the TxWrapper div and into the AntdCollapse Wrapper. Removed TxLink from TxHistory as it is no longer necessary and interferes with the collapse.

Jan 28 2022, 16:15

Jan 26 2022

kieran709 closed D10878: [Cashtab] Added bg color to styled collapse.
Jan 26 2022, 20:31
kieran709 committed rABC571996451114: [Cashtab] Added bg color to styled collapse (authored by kieran709).
[Cashtab] Added bg color to styled collapse
Jan 26 2022, 20:31

Jan 24 2022

kieran709 requested review of D10878: [Cashtab] Added bg color to styled collapse.
Jan 24 2022, 22:13
kieran709 abandoned D10840: [Cashtab] Add background color to styled collapse.

Repushing on a new branch due to issue with commit.

Jan 24 2022, 21:28
kieran709 added inline comments to D10807: [Cashtab] Created TokenIcon component.
Jan 24 2022, 20:48
kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

Rebased, resolved conflicts, updated snapshots.

Jan 24 2022, 20:44
kieran709 requested review of D10869: [Cashtab] Tx history dropdown.
Jan 24 2022, 16:14

Jan 21 2022

kieran709 closed D10838: [Cashtab] Add css prop to TxLink in TxHistory.js.
Jan 21 2022, 15:17
kieran709 committed rABCb62f9cfd91a1: [Cashtab] Add css prop to TxLink in TxHistory.js (authored by kieran709).
[Cashtab] Add css prop to TxLink in TxHistory.js
Jan 21 2022, 15:17

Jan 20 2022

kieran709 updated the summary of D10838: [Cashtab] Add css prop to TxLink in TxHistory.js.
Jan 20 2022, 21:50
kieran709 closed D10845: [Cashtab] Add bg color ant select-selector.
Jan 20 2022, 21:37
kieran709 committed rABC45d0c6fd9ea8: [Cashtab] Add bg color ant select-selector (authored by kieran709).
[Cashtab] Add bg color ant select-selector
Jan 20 2022, 21:37
kieran709 closed D10839: [Cashtab] Add custom styling to Antd Descriptions.
Jan 20 2022, 20:47
kieran709 committed rABC1c524ade67d3: [Cashtab] Add custom styling to Antd Descriptions (authored by kieran709).
[Cashtab] Add custom styling to Antd Descriptions
Jan 20 2022, 20:47
kieran709 closed D10825: [Cashtab] Replace hardcoded colors with references to theme.js.
Jan 20 2022, 19:18
kieran709 committed rABCc203507cf06f: [Cashtab] Replace hardcoded colors with references to theme.js (authored by kieran709).
[Cashtab] Replace hardcoded colors with references to theme.js
Jan 20 2022, 19:18
kieran709 updated the summary of D10847: [Cashtab] Add css props to SwButtnCtn.
Jan 20 2022, 18:20
kieran709 added inline comments to D10845: [Cashtab] Add bg color ant select-selector.
Jan 20 2022, 18:17
kieran709 updated the diff for D10845: [Cashtab] Add bg color ant select-selector.

Responding to review feedback, changed reference in EnhancedInputs.js at line 52 to selectionBackground. Added inline comment to give better understanding of what color I am trying to change. Updated snapshots.

Jan 20 2022, 18:06
kieran709 updated the diff for D10839: [Cashtab] Add custom styling to Antd Descriptions.

Responded to review feedback and updated snapshots.

Jan 20 2022, 17:44
kieran709 updated the test plan for D10839: [Cashtab] Add custom styling to Antd Descriptions.
Jan 20 2022, 17:41
kieran709 updated the summary of D10839: [Cashtab] Add custom styling to Antd Descriptions.
Jan 20 2022, 17:40
kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

Responding to review feedback, removed conditional logic from TokenIcon component. Initially I thought the span wrapping the component was necessary for displaying it inside the popover, but it now appears to be working fine without the span. Additionally, updated snapshots.

Jan 20 2022, 17:28
kieran709 updated the diff for D10825: [Cashtab] Replace hardcoded colors with references to theme.js.

Responding to review feedback, removed references to #fff and added a value, #eee, to the theme.js file.

Jan 20 2022, 14:40

Jan 19 2022

kieran709 requested review of D10847: [Cashtab] Add css props to SwButtnCtn.
Jan 19 2022, 18:04
kieran709 updated the summary of D10840: [Cashtab] Add background color to styled collapse.
Jan 19 2022, 16:27
kieran709 requested review of D10845: [Cashtab] Add bg color ant select-selector.
Jan 19 2022, 16:04

Jan 18 2022

kieran709 requested review of D10840: [Cashtab] Add background color to styled collapse.
Jan 18 2022, 21:20
kieran709 requested review of D10839: [Cashtab] Add custom styling to Antd Descriptions.
Jan 18 2022, 20:21
kieran709 requested review of D10838: [Cashtab] Add css prop to TxLink in TxHistory.js.
Jan 18 2022, 17:49
kieran709 updated the summary of D10837: [Cashtab] Implement dark theme + toggle.
Jan 18 2022, 16:57
kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

Replaced empty wrapper div with a fragment component.

Jan 18 2022, 16:02
kieran709 planned changes to D10837: [Cashtab] Implement dark theme + toggle.

Several references to theme props need to be changed in order for the transition from the light theme to the dark theme to work.

Jan 18 2022, 15:45
kieran709 requested review of D10837: [Cashtab] Implement dark theme + toggle.
Jan 18 2022, 15:43

Jan 14 2022

kieran709 updated the diff for D10825: [Cashtab] Replace hardcoded colors with references to theme.js.

responding to review feedback

Jan 14 2022, 14:42

Jan 13 2022

kieran709 updated the test plan for D10824: [Cashtab] Drag and drop to reorder token list.
Jan 13 2022, 17:45
kieran709 requested review of D10825: [Cashtab] Replace hardcoded colors with references to theme.js.
Jan 13 2022, 16:40
kieran709 updated the summary of D10824: [Cashtab] Drag and drop to reorder token list.
Jan 13 2022, 15:26
kieran709 planned changes to D10824: [Cashtab] Drag and drop to reorder token list.
Jan 13 2022, 15:25
kieran709 requested review of D10824: [Cashtab] Drag and drop to reorder token list.
Jan 13 2022, 15:25
kieran709 updated the diff for D10807: [Cashtab] Created TokenIcon component.

Cleaned up antd popover to include the TokenIcon component.

Jan 13 2022, 12:54

Jan 11 2022

kieran709 closed D10791: [Cashtab] formatDate function patch.
Jan 11 2022, 19:39
kieran709 committed rABC8608f16e05ee: [Cashtab] formatDate function patch (authored by kieran709).
[Cashtab] formatDate function patch
Jan 11 2022, 19:39
kieran709 abandoned D10817: [Cashtab] redirect to wallet tab on send.
Jan 11 2022, 19:37
kieran709 updated the summary of D10817: [Cashtab] redirect to wallet tab on send.
Jan 11 2022, 19:07
kieran709 requested review of D10817: [Cashtab] redirect to wallet tab on send.
Jan 11 2022, 19:05
kieran709 updated the diff for D10791: [Cashtab] formatDate function patch.

hard coded en-US into all unit tests per review feedback.

Jan 11 2022, 18:46
kieran709 closed D10776: [Cashtab] Format XEC on send form.
Jan 11 2022, 15:29
kieran709 committed rABC91273a0907ce: [Cashtab] Format XEC on send form (authored by kieran709).
[Cashtab] Format XEC on send form
Jan 11 2022, 15:29

Jan 10 2022

kieran709 planned changes to D10807: [Cashtab] Created TokenIcon component.

Still working on rendering the component in the SendToken popover.

Jan 10 2022, 16:11
kieran709 requested review of D10807: [Cashtab] Created TokenIcon component.
Jan 10 2022, 16:04
kieran709 updated the diff for D10776: [Cashtab] Format XEC on send form.

updated imports

Jan 10 2022, 15:38
kieran709 updated the diff for D10791: [Cashtab] formatDate function patch.

Responding to review feedback, hardcoded the userLocale param to equal en and removed the optional locale param from the new Date function in the unit tests.

Jan 10 2022, 15:05

Jan 7 2022

kieran709 requested review of D10791: [Cashtab] formatDate function patch.
Jan 7 2022, 20:59
kieran709 closed D10777: [Cashtab] Move formatting functions and tests to their own util files.
Jan 7 2022, 18:54
kieran709 committed rABCe0f1fe857e1f: [Cashtab] Move formatting functions and tests to their own util files (authored by kieran709).
[Cashtab] Move formatting functions and tests to their own util files
Jan 7 2022, 18:54

Jan 6 2022

kieran709 updated the diff for D10776: [Cashtab] Format XEC on send form.

updated snapshots

Jan 6 2022, 21:02
kieran709 updated the diff for D10776: [Cashtab] Format XEC on send form.

Added optional userLocale to formatFiatbalance functions throughout, and used styling from master theme.

Jan 6 2022, 21:01
kieran709 requested review of D10777: [Cashtab] Move formatting functions and tests to their own util files.
Jan 6 2022, 20:35
kieran709 updated the diff for D10776: [Cashtab] Format XEC on send form.

updated snapshots

Jan 6 2022, 17:59
kieran709 requested review of D10776: [Cashtab] Format XEC on send form.
Jan 6 2022, 17:56
kieran709 abandoned D10746: [Cashtab] Format XEC amount on input.
Jan 6 2022, 17:47
kieran709 updated the diff for D10746: [Cashtab] Format XEC amount on input.

added function I mistakenly removed

Jan 6 2022, 17:41
kieran709 updated the diff for D10746: [Cashtab] Format XEC amount on input.

responding to review feedback

Jan 6 2022, 17:39

Jan 5 2022

kieran709 closed D10767: [Cashtab] Remove dirty param from SendToken formData.
Jan 5 2022, 17:53
kieran709 committed rABCbcb1c9d02177: [Cashtab] Remove dirty param from SendToken formData (authored by kieran709).
[Cashtab] Remove dirty param from SendToken formData
Jan 5 2022, 17:53
kieran709 closed D10763: [Cashtab] Removed unused var from Send.js. .
Jan 5 2022, 17:21
kieran709 committed rABCeec77180a3ea: [Cashtab] Removed unused var from Send.js. (authored by kieran709).
[Cashtab] Removed unused var from Send.js.
Jan 5 2022, 17:21
kieran709 closed D10652: [Cashtab] Change date format.
Jan 5 2022, 17:02