Page MenuHomePhabricator
Feed Advanced Search

May 14 2022

Fabien empowered sdulfari as an administrator.
May 14 2022, 16:35
sdulfari requested review of D11468: [avalanche] Ensure nullptr safety on proccesor's public interface.
May 14 2022, 13:15
sdulfari accepted D11465: [avalanche] Rename the ProofComparator.
May 14 2022, 00:25
sdulfari updated the diff for D11457: [avalanche] Reject votes that have been inconclusive for too many rounds.

Fix the approach so that instead of stopping avalanche on the inconclusive item, we continue
with a reject vote. This way, we retain network consistency but are still able to tip the
network to finalize a rejection and not let a vote dangle.

May 14 2022, 00:23

May 13 2022

sdulfari requested review of D11464: Lint test_framework/messages.py.
May 13 2022, 23:38
sdulfari requested review of D11457: [avalanche] Reject votes that have been inconclusive for too many rounds.
May 13 2022, 00:44

May 12 2022

sdulfari requested changes to D11388: [avalanche] Answer getavaproofs message with short proof ids.
May 12 2022, 21:07
sdulfari closed D11452: [avalanche] Fix logging of vote statuses.
May 12 2022, 16:57
sdulfari committed rABC8e43311b0101: [avalanche] Fix logging of vote statuses (authored by sdulfari).
[avalanche] Fix logging of vote statuses
May 12 2022, 16:57
sdulfari closed D11451: [avalanche] Fix proof voting response type.
May 12 2022, 06:42
sdulfari committed rABCe6e75c178b54: [avalanche] Fix proof voting response type (authored by sdulfari).
[avalanche] Fix proof voting response type
May 12 2022, 06:42
sdulfari requested review of D11452: [avalanche] Fix logging of vote statuses.
May 12 2022, 06:34
sdulfari requested changes to D11450: [avalanche] Maintain a radix tree of the proofs.

Generally true throughout this diff: the naming is too dependent on the underlying proofs database being a radix tree. A simple example at the peer manager interface is getProofRadixTree(). Does the caller care that the DB is a radix tree? If we change to some other COW DB, we'll end up with a lot of renaming to do.

May 12 2022, 00:34

May 11 2022

sdulfari requested review of D11451: [avalanche] Fix proof voting response type.
May 11 2022, 23:26

May 10 2022

sdulfari accepted D11405: Let the radix tree work with 256 bits keys.
May 10 2022, 20:38
sdulfari accepted D11405: Let the radix tree work with 256 bits keys.
May 10 2022, 15:29

May 9 2022

sdulfari added inline comments to D11405: Let the radix tree work with 256 bits keys.
May 9 2022, 22:17
sdulfari requested changes to D11405: Let the radix tree work with 256 bits keys.
May 9 2022, 21:34

May 6 2022

sdulfari accepted D11433: net_processing: move some globals into PeerManagerImpl.

Maybe mention in the summary that changes related to g_wtxid_relay_peers are not present because these are for segwit.

May 6 2022, 23:39
sdulfari updated the summary of D11431: [avalanche] Make proof replacement check explicit.
May 6 2022, 23:09
sdulfari updated the diff for D11431: [avalanche] Make proof replacement check explicit.

Attempt to handle unexpected DUPLICATED case gracefully

May 6 2022, 23:08
sdulfari closed D11432: [avalanche] Consolidate duplicate code for moving proofs to conflicting pool.
May 6 2022, 22:33
sdulfari committed rABC1e7b869da4b3: [avalanche] Consolidate duplicate code for moving proofs to conflicting pool (authored by sdulfari).
[avalanche] Consolidate duplicate code for moving proofs to conflicting pool
May 6 2022, 22:33
sdulfari requested review of D11432: [avalanche] Consolidate duplicate code for moving proofs to conflicting pool.
May 6 2022, 04:04
sdulfari added inline comments to D11431: [avalanche] Make proof replacement check explicit.
May 6 2022, 00:15
sdulfari updated the summary of D11431: [avalanche] Make proof replacement check explicit.
May 6 2022, 00:12
sdulfari requested review of D11431: [avalanche] Make proof replacement check explicit.
May 6 2022, 00:09

May 5 2022

sdulfari accepted D11421: Add a traversal method for the radix tree.
May 5 2022, 18:35
sdulfari requested changes to D11421: Add a traversal method for the radix tree.

A quick mention of what you intend to do with this would be helpful since it's not currently used except for its own test.

May 5 2022, 16:42

May 4 2022

sdulfari closed D11407: Rename radix typename for key type to something searchable.
May 4 2022, 20:08
sdulfari committed rABC9bd7eb3de72a: Rename radix typename for key type to something searchable (authored by sdulfari).
Rename radix typename for key type to something searchable
May 4 2022, 20:08
sdulfari requested review of D11407: Rename radix typename for key type to something searchable.
May 4 2022, 01:44

Apr 29 2022

sdulfari closed D11399: Fix swapped max and default diff settings in mining post.
Apr 29 2022, 16:49
sdulfari committed rABCWEBaba104480b60: Fix swapped max and default diff settings in mining post (authored by sdulfari).
Fix swapped max and default diff settings in mining post
Apr 29 2022, 16:49
sdulfari closed D11398: Add sane instructions for rvm setup.
Apr 29 2022, 16:48
sdulfari committed rABCWEB6709a8d603c3: Add sane instructions for rvm setup (authored by sdulfari).
Add sane instructions for rvm setup
Apr 29 2022, 16:48

Apr 28 2022

sdulfari requested review of D11399: Fix swapped max and default diff settings in mining post.
Apr 28 2022, 23:56
sdulfari requested review of D11398: Add sane instructions for rvm setup.
Apr 28 2022, 23:48
sdulfari added inline comments to D11340: Add an option to allow for bypassing the network group limit on outbound connections.
Apr 28 2022, 21:06
sdulfari accepted D11397: use c++ 17 structured binding in cashaddr related code.
Apr 28 2022, 20:42
sdulfari requested changes to D11390: [avalanche] Bypass net group limits by default for avalanche outbounds.

This single flag is trying to do two jobs, so it ends up being a tri-state switch, which I doubt is expected by the user:

  • Unset - non-avalanche connections do not bypass, but avalanche connections do
  • True - all connections bypass
  • False - no connections bypass
Apr 28 2022, 20:24
sdulfari accepted D11396: Use incrementRefCount and decrementRefCount in the radix code too.
Apr 28 2022, 16:36
sdulfari closed D11386: Reflow eCash section of the README.
Apr 28 2022, 15:55
sdulfari committed rABC8fa710cebb43: Reflow eCash section of the README (authored by sdulfari).
Reflow eCash section of the README
Apr 28 2022, 15:55

Apr 26 2022

sdulfari requested review of D11386: Reflow eCash section of the README.

done

Apr 26 2022, 16:07
sdulfari updated the summary of D11386: Reflow eCash section of the README.
Apr 26 2022, 16:07

Apr 25 2022

sdulfari requested review of D11386: Reflow eCash section of the README.
Apr 25 2022, 21:55
sdulfari updated sdulfari.
Apr 25 2022, 21:48

Apr 22 2022

sdulfari closed D11381: Rewrite README intro to be more objective.
Apr 22 2022, 16:55
sdulfari committed rABCea94626afbe7: Rewrite README intro to be more objective (authored by sdulfari).
Rewrite README intro to be more objective
Apr 22 2022, 16:55

Apr 21 2022

sdulfari requested review of D11381: Rewrite README intro to be more objective.
Apr 21 2022, 22:52
sdulfari closed D11379: Rename Bitcoin Cash to eCash in backporting instructions + minor fixes.
Apr 21 2022, 17:14
sdulfari committed rABC2e5ba447b21d: Rename Bitcoin Cash to eCash in backporting instructions + minor fixes (authored by sdulfari).
Rename Bitcoin Cash to eCash in backporting instructions + minor fixes
Apr 21 2022, 17:14
sdulfari closed D11378: Fix missed renaming to eCash.
Apr 21 2022, 17:11
sdulfari committed rABC8ff253fda504: Fix missed renaming to eCash (authored by sdulfari).
Fix missed renaming to eCash
Apr 21 2022, 17:11
sdulfari closed D11377: Fix typo in disclosure.
Apr 21 2022, 17:10
sdulfari committed rABC707067097789: Fix typo in disclosure (authored by sdulfari).
Fix typo in disclosure
Apr 21 2022, 17:10
sdulfari requested review of D11379: Rename Bitcoin Cash to eCash in backporting instructions + minor fixes.
Apr 21 2022, 16:46
sdulfari requested review of D11378: Fix missed renaming to eCash.
Apr 21 2022, 16:40
sdulfari requested review of D11377: Fix typo in disclosure.
Apr 21 2022, 16:38

Apr 20 2022

sdulfari set Slack Username to sdulfari on sdulfari.
Apr 20 2022, 20:12