@bot preview-e.cash

Add hash.h

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://54.39.104.128:41670 for the next 60 minutes.

In D16627#376897, @Fabien wrote:

Update ecash-herald, token-server, and Cashtab to handle this new type.

Because you aliased ChronikNodeClient this can (and should) be done in subsequent diffs.

rebase, back out ChronikClientNode to ChronikClient rename in monorepo apps

@bot preview-explorer

Update ecash-herald, token-server, and Cashtab to handle this new type.

• cleanups
• strongly type StakeContenderId
• switch to blockhash + proofid instead of blockhash + payoutscript since this could be more versatile down the road
• streamlined implementation a bit, which eliminated stakecontender.cpp

lmao the 'lgtm' auto meme posting!? is that custom or built in phab feature haha

supposed to be a draft

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41660 for the next 60 minutes.

@bot preview-e.cash

expand function to be more like isAddressEligible ... no need for just a chronik wrapper

Removed the complex code and added an explicit height for images in styles which will
fix issues with tall images.

I just saw John's comment. I will apply his changes for now and remove mine.

Okay, some images already have this kind of adjustment on them (e.g.: core tech) , but I agree that the source files need to be corrected. In fact I suggest alternative images to begin with. I will create a new task where I show the alternative imagery we could use and the reason for scrapping these hand-animations altogether. But that is something for a later date I presume.

I think the issue is with the subPageHero component.
The min height of the container does not account for the top padding and image height. So tall images are overflowing into the nav and shorter screens.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.63:41644 for the next 60 minutes.

@bot preview-e.cash

imo this is an overcomplicated fix that is likely to cause more problems than it solves. the picture of the original problem -- interference with the nav menu on some devices/resolutions -- does not seem that bad.

alias in this implementation actually breaks ChronikClient usage ... only ChronikClientNode works

alias in this implementation actually breaks ChronikClient usage ... only ChronikClientNode works

rebase, alias ChronikClient as ChronikClientNode to preserve existing implementations

That's how it looks for me and Aimal:

address review

Is this specific to some screen size ? On my monitor it just makes the animation appear slightly off center offset to the bottom. I have no issue with the current version also.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41398 for the next 60 minutes.

@bot preview-e.cash

I think some of these examples can still be useful to maintain but not as part of the functional tests nor independently, but as part of chronik-docs (like a minimal wallet).

In D16629#376598, @bytesofman wrote:

In D16629#376587, @teamcity wrote:

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

test failure related to tests no longer existing. this is removed in the yml but not picked up by existing CI

I mostly agree with the deprecation plan except for 1 thing: you should alias ChronikClientNode to ChronikClient. This makes it so that you don't need to update the libs that use ChronikClientNode (can be moved in their own diff). It also release pressure on devs to update as their current in-node chronik code will keep working with the new version.

I think such a small change should just be inlined, it doesn't bring any value on its own.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41972 for the next 60 minutes.

@bot preview-e.cash

[e.cash] Rename Navitem Button to What's eCash