I am right now renaming the button inside navitems but it does not change the Tab. Both the landing page as well as the what's eCash page show "eCash | Wealth Redefined" in the browser tab. I could not find the place where to change it.

need to update data/navitems.js -- the nav menu still calls the page "Wealth Redefined"

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41915 for the next 60 minutes.

@bot preview-e.cash

I have written "the ideal internet cash" instead of cash for the internet, so there is not too much repetition. it still keeps the cash and the internet, so I think that works.

applied suggested changes, renamed to what-is-ecash,
and added redirect

In D16629#376587, @teamcity wrote:

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

css tweaks to match existing functionality and look

some css tweaks to fix described issues

some style differences in testing

Much better copy and yeah Wealth Redefined does not make sense as a page. A couple of cosmetic suggestions.

<utf8 unique identifier>

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41164 for the next 60 minutes.

@bot preview-e.cash

Updated authentication tx msg and added reference to spec

Updated article paywall render to be an explorer link, removed invalid article id renders and added reference to spec.

Look at your own test, is that really what you would expect to be printed by the herald ? Start with what it should look like first

In D16611#376298, @bytesofman wrote:

In D16611#376253, @Fabien wrote:

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

added to the Address page

I looked at also adding it to the transactions table -- e.g. on the block page -- this though requires a different implementation. I don't think it would be that complicated, but might need to repeat the url constant as this table is built by a JS file and not the template. I don't think we really need it there though.

In D16606#376385, @bytesofman wrote:

In D16606#376342, @emack wrote:

Clicking the copy icon for txid at the top gives this

Whilst clicking the copy icon for the addresses triggers the tooltip but no response. Have verified address has not been copied to clipboard.

Ok I was able to repeat this in a diff that makes no changes from master except a token test text change

D16622

So -- there is some issue where the JS does not work on explorer previews, prob related to not being https, would have to troubleshoot -- anyway not related to this diff

test with cargo run locally

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41917 for the next 60 minutes.

@bot preview-explorer

version bump

Going forward, diffs like this should also add support to the herald. Otherwise we will keep getting more divergence.

In D16606#376342, @emack wrote:

Clicking the copy icon for txid at the top gives this

Whilst clicking the copy icon for the addresses triggers the tooltip but no response. Have verified address has not been copied to clipboard.

In D16606#376342, @emack wrote:

Clicking the copy icon for txid at the top gives this

Whilst clicking the copy icon for the addresses triggers the tooltip but no response. Have verified address has not been copied to clipboard.

Updated comments

Clicking the copy icon for txid at the top gives this

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.83.66.92:41482 for the next 60 minutes.

@bot preview-explorer

In D16611#376253, @Fabien wrote:

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

use constant for token server url, add to Address page, ensure size constraint

use brackets to clean up copyString function

In D16606#376261, @Fabien wrote:

This doesn't work for me. I see the icon and the tooltip but on click I get TypeError: navigator.clipboard is undefined (Firefox on linux)

This doesn't work for me. I see the icon and the tooltip but on click I get TypeError: navigator.clipboard is undefined (Firefox on linux)

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41698 for the next 60 minutes.

@bot preview-explorer

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

I don't think this is a good change. It seems more useful and more the expected behavior for a token transaction to show the token address, and the simplification is not a big gain in this case. I get the point that you can select your address format in the address page but I don't think it compensates for the annoyance.