Page MenuHomePhabricator
Feed Advanced Search

Feb 27 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

only call slpSend with bigints

Feb 27 2025, 22:37
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase, name/type/spacing nit updates per comments

Feb 27 2025, 22:02
bytesofman added inline comments to D17701: [Cashtab] Support one-click redemptions.
Feb 27 2025, 14:05
bytesofman added a comment to D17701: [Cashtab] Support one-click redemptions.

Consider a 100% 50% 25% button above the Redeem button similar to binance. Easier for tax calculations when people are just partially selling rounded percentages.

Feb 27 2025, 14:04
bytesofman updated the diff for D17701: [Cashtab] Support one-click redemptions.

Show "you receive" amount for FIRMA redemptions

Feb 27 2025, 14:03
bytesofman accepted D17712: [e.cash] Update copy on Build page.

some suggestions trying to tighten up the copy, go with whatever you think is best. I don't think anyone reads something longer than a full sentence on the internet anymore. But we really only need a handful of people who "get it" to see this stuff, so I don't think we need to worry about general consumption too much here.

Feb 27 2025, 04:07
bytesofman added a comment to D17712: [e.cash] Update copy on Build page.

@bot preview-e.cash

Feb 27 2025, 03:58
bytesofman added a comment to D17712: [e.cash] Update copy on Build page.

@bot preview-e.cash

Feb 27 2025, 01:10

Feb 26 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update proto script, patch lingering "value:" keys in READMEs, downstream impacts of proto script update (other bigints, type handling)

Feb 26 2025, 22:54
bytesofman published D17708: [Cashtab] Update token scam prevention list for review.
Feb 26 2025, 18:31
bytesofman published D17709: [Cashtab] Parse firma yield txs for review.
Feb 26 2025, 18:30
bytesofman published D17701: [Cashtab] Support one-click redemptions for review.
Feb 26 2025, 17:08
bytesofman abandoned D17328: [token-server] Bump free xec from 42 to 88.

i think will just forget about this for now. we have good demand for the 42-xec reward and no one has complained about it being insufficient.

Feb 26 2025, 15:08
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

patch implementation of reduce in cashtab transactions (do not mix bigint and number)

Feb 26 2025, 13:29
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase, bigint in reduce, bigint math for token rewards in herald, camelCase patches in ecash-agora, var name patches in cashtab constants, hex instead of decimal for hex-defined constants

Feb 26 2025, 12:57
bytesofman added inline comments to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 26 2025, 12:52

Feb 25 2025

bytesofman published D17697: [Cashtab] Make sure whitelisted agora tokens load cache first for review.
Feb 25 2025, 14:05

Feb 21 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

remove debug log

Feb 21 2025, 14:53
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase

Feb 21 2025, 14:24
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more finds

Feb 21 2025, 13:56
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more atoms_vec finds

Feb 21 2025, 13:35
bytesofman added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

apologies for the phab noise here ... not sure how to find all these locally. ninja check-functional is passing

Feb 21 2025, 12:43
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more atoms_vec

Feb 21 2025, 05:06
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

test patch

Feb 21 2025, 00:40
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more script patches, update other amounts params

Feb 21 2025, 00:27

Feb 20 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

chronik updates from name changes in mint data

Feb 20 2025, 23:56
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update more names, implement

Feb 20 2025, 23:25
bytesofman added inline comments to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 20 2025, 23:20
bytesofman accepted D17680: [chronik-client] Fix a bug in the plugins integration test.
Feb 20 2025, 14:52

Feb 19 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update mock to new shape

Feb 19 2025, 17:53
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update types in chronik-http/src/electrum.rs

Feb 19 2025, 17:02
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase, remove debug logs, remove duplicated branch in cashtab wallet migration, revert unrelated lint change in Configure.test.js

Feb 19 2025, 15:48
bytesofman published D17678: [Cashtab] Improve test match syntax for token actions for review.
Feb 19 2025, 15:34

Feb 16 2025

bytesofman closed D17666: [Cashtab] Dep upgrades.
Feb 16 2025, 22:49
bytesofman committed rABC601bffd332c3: [Cashtab] Dep upgrades (authored by bytesofman).
[Cashtab] Dep upgrades
Feb 16 2025, 22:49

Feb 15 2025

bytesofman accepted D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.

please update the ecash-lib change-log per usual version bump (link to this diff, brief description)

Feb 15 2025, 21:35
bytesofman published D17666: [Cashtab] Dep upgrades for review.
Feb 15 2025, 17:18

Feb 11 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

ecash-herald copyright update, ecash-agora camelCase patches, rust proto tighten comment line length

Feb 11 2025, 13:23
bytesofman added inline comments to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 11 2025, 13:19
bytesofman published D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens) for review.
Feb 11 2025, 04:30

Feb 7 2025

bytesofman closed D17649: [Cashtab] Improve form entry UX for agora listings.
Feb 7 2025, 23:20
bytesofman committed rABCe0e012e32845: [Cashtab] Improve form entry UX for agora listings (authored by bytesofman).
[Cashtab] Improve form entry UX for agora listings
Feb 7 2025, 23:20
bytesofman closed D17641: [Cashtab] Support one-click redemptions for XECX.
Feb 7 2025, 22:42
bytesofman committed rABC3d80d5ddb170: [Cashtab] Support one-click redemptions for XECX (authored by bytesofman).
[Cashtab] Support one-click redemptions for XECX
Feb 7 2025, 22:42
bytesofman published D17649: [Cashtab] Improve form entry UX for agora listings for review.
Feb 7 2025, 18:38
bytesofman closed D17648: [ecash-agora] Do not validate for unspendable offers when estimating the fee.
Feb 7 2025, 17:27
bytesofman committed rABC63bebf069004: [ecash-agora] Do not validate for unspendable offers when estimating the fee (authored by bytesofman).
[ecash-agora] Do not validate for unspendable offers when estimating the fee
Feb 7 2025, 17:27
bytesofman published D17648: [ecash-agora] Do not validate for unspendable offers when estimating the fee for review.
Feb 7 2025, 14:40
bytesofman added a comment to D17641: [Cashtab] Support one-click redemptions for XECX.

Unable to redeem 7ish XECX for XEC, this is above dust so should be possible?

image.png (286×1 px, 19 KB)

Redemption worked fine for 10k XECX.

Feb 7 2025, 13:27
bytesofman updated the diff for D17641: [Cashtab] Support one-click redemptions for XECX.

show dust error

Feb 7 2025, 13:24
bytesofman closed D17647: [Cashtab] Patch price display in agora cancel modal.
Feb 7 2025, 13:02
bytesofman committed rABCb8d3cec46ed6: [Cashtab] Patch price display in agora cancel modal (authored by bytesofman).
[Cashtab] Patch price display in agora cancel modal
Feb 7 2025, 13:02

Feb 6 2025

bytesofman published D17647: [Cashtab] Patch price display in agora cancel modal for review.
Feb 6 2025, 22:42
bytesofman accepted D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.
Feb 6 2025, 18:23
bytesofman abandoned D17464: [ecash-lib] attach ecc and hashes to globalThis.
Feb 6 2025, 18:09
bytesofman published D17641: [Cashtab] Support one-click redemptions for XECX for review.
Feb 6 2025, 18:09
bytesofman requested changes to D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

changelog update to explain major version bump in ecash-agora

Feb 6 2025, 17:55
bytesofman added a comment to D17639: [ecash-lib] Remove `initWasm`.

everyone will have to build the webassembly, even if they don't use any ECC.

Feb 6 2025, 13:45
bytesofman added a comment to D17639: [ecash-lib] Remove `initWasm`.

Why minor here and patch in D17640 ?

Feb 6 2025, 13:42
bytesofman added inline comments to D17639: [ecash-lib] Remove `initWasm`.
Feb 6 2025, 13:40
bytesofman requested changes to D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

nice, step change in UX. much much much better for app devs.

Feb 6 2025, 05:37
bytesofman accepted D17639: [ecash-lib] Remove `initWasm`.

nice, huge step change for dev experience, and esp for apps that use ecash-lib and ecash-agora

Feb 6 2025, 05:22

Feb 5 2025

bytesofman updated the test plan for D17464: [ecash-lib] attach ecc and hashes to globalThis.
Feb 5 2025, 15:28
bytesofman updated the diff for D17464: [ecash-lib] attach ecc and hashes to globalThis.

update uninitialized interface

Feb 5 2025, 13:04
bytesofman updated the diff for D17464: [ecash-lib] attach ecc and hashes to globalThis.

rebase

Feb 5 2025, 12:51
bytesofman closed D17637: [ecash-agora] Move helper functions to get utxos for accepting and canceling agora txs from Cashtab to ecash-agora.
Feb 5 2025, 12:30
bytesofman committed rABCc20187c89c17: [ecash-agora] Move helper functions to get utxos for accepting and canceling… (authored by bytesofman).
[ecash-agora] Move helper functions to get utxos for accepting and canceling…
Feb 5 2025, 12:30
bytesofman closed D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.
Feb 5 2025, 12:12
bytesofman committed rABC211cb2755209: [ecash-agora] Do not include offers that have not been bought or canceled in… (authored by bytesofman).
[ecash-agora] Do not include offers that have not been bought or canceled in…
Feb 5 2025, 12:12
bytesofman published D17637: [ecash-agora] Move helper functions to get utxos for accepting and canceling agora txs from Cashtab to ecash-agora for review.
Feb 5 2025, 03:54

Feb 4 2025

bytesofman added a comment to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

I think the diff is worth landing as is although it may not yet be comprehensive.

Feb 4 2025, 18:03
bytesofman updated the diff for D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

more robust check

Feb 4 2025, 17:37
bytesofman added a comment to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

So, this is not an exhaustive check; it just patches one (probably the most common) error case.

Feb 4 2025, 17:22
bytesofman planned changes to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

image.png (68×317 px, 6 KB)

Can you provide some context on how to validate this output from the script above and that it is indeed excluding the not-bought or cancelled offers?

Feb 4 2025, 14:25
bytesofman published D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers for review.
Feb 4 2025, 00:57

Feb 3 2025

bytesofman closed D17623: [ecash-lib] Better behavior of withPrefix() method in Address class.
Feb 3 2025, 12:49
bytesofman committed rABC12cff4fe1b5c: [ecash-lib] Better behavior of withPrefix() method in Address class (authored by bytesofman).
[ecash-lib] Better behavior of withPrefix() method in Address class
Feb 3 2025, 12:49
bytesofman closed D17625: [Cashtab] Always show send button on send screen.
Feb 3 2025, 04:19
bytesofman committed rABCe27f29ba4083: [Cashtab] Always show send button on send screen (authored by bytesofman).
[Cashtab] Always show send button on send screen
Feb 3 2025, 04:19
bytesofman closed D17628: [Cashtab] Do not wordbreak break-all for XECX summaries.
Feb 3 2025, 03:37
bytesofman committed rABC94b85cf554c2: [Cashtab] Do not wordbreak break-all for XECX summaries (authored by bytesofman).
[Cashtab] Do not wordbreak break-all for XECX summaries
Feb 3 2025, 03:37
bytesofman closed D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 03:35
bytesofman committed rABC9b9a406c97e4: [Cashtab] Make sure hide balance toggle also hides XECX balance (authored by bytesofman).
[Cashtab] Make sure hide balance toggle also hides XECX balance
Feb 3 2025, 03:35
bytesofman added inline comments to D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 03:34
bytesofman published D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance for review.
Feb 3 2025, 00:54
bytesofman published D17628: [Cashtab] Do not wordbreak break-all for XECX summaries for review.
Feb 3 2025, 00:24

Feb 2 2025

bytesofman added a comment to D17625: [Cashtab] Always show send button on send screen.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

Feb 2 2025, 19:10
bytesofman updated the diff for D17625: [Cashtab] Always show send button on send screen.

give button container background color so scroll-behind looks cleaner, line it up with app buttons on mobile

Feb 2 2025, 19:08
bytesofman abandoned D17626: [Cashtab] Show close modal if window fails to close programmatically.

only reason to do this was potential safari behavior (that, if true, this diff would potentially not resolve)

Feb 2 2025, 14:28
bytesofman closed D17624: [Cashtab] Patch button css.
Feb 2 2025, 14:19
bytesofman committed rABCb6b377f844aa: [Cashtab] Patch button css (authored by bytesofman).
[Cashtab] Patch button css
Feb 2 2025, 14:19
bytesofman updated the test plan for D17626: [Cashtab] Show close modal if window fails to close programmatically.
Feb 2 2025, 00:46
bytesofman published D17626: [Cashtab] Show close modal if window fails to close programmatically for review.
Feb 2 2025, 00:45

Feb 1 2025

bytesofman updated the diff for D17625: [Cashtab] Always show send button on send screen.

version bump + extension bump

Feb 1 2025, 23:54
bytesofman published D17625: [Cashtab] Always show send button on send screen for review.
Feb 1 2025, 23:48
bytesofman published D17624: [Cashtab] Patch button css for review.

note the test failure is from when I first put the diff up having accidentally deleted the file

Feb 1 2025, 23:32
bytesofman published D17623: [ecash-lib] Better behavior of withPrefix() method in Address class for review.
Feb 1 2025, 00:00

Jan 31 2025

bytesofman accepted D17622: [ecash-lib] Support custom WASM URL and module.
Jan 31 2025, 21:58
bytesofman accepted D17621: [ecash-lib] Patch import in `mnemonic.ts`.
Jan 31 2025, 20:53
bytesofman accepted D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.

This not-quite doubles the package size (compressed: 150.4 kB -> 245.0 kB, uncompressed: 564.2 kB -> 934.9 kB), but since we still stay below 1 MB even uncompressed this doesn't seem to be a big issue

Jan 31 2025, 14:23