otherwise the code is fine, diff is ready to roll with exception of mystery git basis / arc patch issue

mb it's not the best git-fu but in my experience it's almost always easier to recreate a diff with a single commit when phab/git raise issues (vs attempt to squash / update all the necessary arcanist stuff...who knows what's in there or what it was originally based on).

looks like this is not based on the latest master or is accidentally a stack

remove another XecWallet mention

more fixes from the rename and constructor change, better property comments

remove redundant interface, change name to Wallet, private constructor with fromSk static method helper constructor

preserve attribution headers in ecashaddrjs, keep ignores in the top-level .gitignore

actually back out the changes in net.cpp

newline net.cpp to back out unrelated autofix

newlines to back out unrelated autofixes

backing out unrelated autofixes from arc lint everything

running arc lint --everything and taking some autofixes

patch py lint issue (handled in separate diff), exclude src/ which has .ts files that are not typescript

In D17755#404513, @emack wrote:

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

On another note, I'm getting the following from arc lint --everything

However, arc lint on the cashtab folder runs fine, which doesn't seem to be a local issue?

superseded by D17755

CI failure expected with the lib removed.

going to put some more thought into this, prob do a one-shot diff that implements this upgrade everywhere.

improve linter install instructions, add mjs

Show a spinner while the redeem listing is calculated

In D17701#403631, @emack wrote:

I no longer see the redeem button anymore even though I have a FIRMA balance and am on the FIRMA token landing page.

v3.14.0 on the netlify instance after multiple refreshes

rebase

rebase

rebase

rebase