handle_header -> handle_block_header
Feed All Stories
Aug 1 2024
Aug 1 2024
PiRK requested changes to D16567: depends: set two CMake options globally.
We are not using libmultiprocess
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.
teamcity added a comment to D16567: depends: set two CMake options globally.
Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.
teamcity added a comment to D16567: depends: set two CMake options globally.
Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.
teamcity added a comment to D16567: depends: set two CMake options globally.
Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.
teamcity awarded D16566: depends: always configure with --with-pic a Haypence token.
Fabien added a comment to D16566: depends: always configure with --with-pic.
@bot guix-linux guix-osx guix-win
teamcity awarded D16567: depends: set two CMake options globally a Haypence token.
Fabien added a comment to D16567: depends: set two CMake options globally.
@bot guix-linux guix-osx guix-win
Fabien updated the summary of D16567: depends: set two CMake options globally.
teamcity awarded D16565: depends: build miniupnpc with CMake a Doubloon token.
Fabien added a comment to D16565: depends: build miniupnpc with CMake.
@bot guix-linux guix-osx guix-win
Fabien updated the summary of D16565: depends: build miniupnpc with CMake.
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.
Rebase on D16567 to fix the lib
teamcity updated the summary of D16567: depends: set two CMake options globally.
Fabien requested review of D16567: depends: set two CMake options globally.
teamcity updated the summary of D16566: depends: always configure with --with-pic.
Fabien requested review of D16566: depends: always configure with --with-pic.
Fabien planned changes to D16565: depends: build miniupnpc with CMake.
PiRK added a comment to D16565: depends: build miniupnpc with CMake.
Symbol check is now failing. Not sure why it previously didn't pick up libminiupnpc, but now it does.
FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/CMakeFiles/symbol-check-bitcoin-qt 21:14:08 cd /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt 21:14:08 /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: libminiupnpc.so.17 is not in ALLOWED_LIBRARIES! 21:14:08 /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: failed LIBRARY_DEPENDENCIES
johnkuney updated the diff for D16556: [e.cash] Landing page design updates.
animation and content tweaks
Jul 31 2024
Jul 31 2024
[Automated] Update electrum checkpoints
Klakurka added a comment to D16556: [e.cash] Landing page design updates.
- Any way that we can improve the slide in? The border between the animated bg and the plain colour bg doesn't look great.
- Maybe clean up some of the little "bits" that make the hand look dirty (from the merged of the two images).
- How about removing the tx fee mention? Simpler is usually better. Low tx fees is hardly a stand-out feature when somebody is comparing across shitcoins.
teamcity added a comment to D16556: [e.cash] Landing page design updates.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) failed.
teamcity awarded D16556: [e.cash] Landing page design updates a Mountain of Wealth token.
Kronkmeister added a comment to D16556: [e.cash] Landing page design updates.
teamcity added a comment to D16556: [e.cash] Landing page design updates.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41784 for the next 60 minutes.
teamcity awarded D16556: [e.cash] Landing page design updates a Doubloon token.
Klakurka added a comment to D16556: [e.cash] Landing page design updates.
@bot preview-e.cash
Mengerian added inline comments to D16556: [e.cash] Landing page design updates.
Mengerian requested changes to D16556: [e.cash] Landing page design updates.
Overall this looks great!
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
teamcity awarded D16565: depends: build miniupnpc with CMake a Piece of Eight token.
Fabien added a comment to D16565: depends: build miniupnpc with CMake.
@bot guix-linux guix-osx guix-win
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.
Our cmake call sets the generator to ninja, so don't build with make
Fabien committed rABCcd7a9ae313ee: depends: patch libool out of libnatpmp/miniupnpc (authored by Cory Fields <cory-nospam-@coryfields.com>).
depends: patch libool out of libnatpmp/miniupnpc
Fabien committed rABC62af58c8a4a6: build: fix mingw miniupnpc cflags (authored by fanquake <fanquake@gmail.com>).
build: fix mingw miniupnpc cflags
Fabien committed rABC12144825fb38: build: miniupnpc 2.2.2 (authored by fanquake <fanquake@gmail.com>).
build: miniupnpc 2.2.2
Fabien planned changes to D16565: depends: build miniupnpc with CMake.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.
teamcity added a comment to D16565: depends: build miniupnpc with CMake.
Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.
Extract tx pool outside of txorphanage
teamcity awarded D16565: depends: build miniupnpc with CMake a Haypence token.
Fabien added a comment to D16565: depends: build miniupnpc with CMake.
@bot guix-linux guix-osx guix-win
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.
Fix merge issue in dependencies.md
teamcity updated the summary of D16565: depends: build miniupnpc with CMake.
Fabien requested review of D16565: depends: build miniupnpc with CMake.
teamcity awarded D16564: depends: patch libool out of libnatpmp/miniupnpc a Haypence token.
Fabien added a comment to D16564: depends: patch libool out of libnatpmp/miniupnpc.
@bot guix-linux guix-osx guix-win
teamcity updated the summary of D16564: depends: patch libool out of libnatpmp/miniupnpc.
Fabien requested review of D16564: depends: patch libool out of libnatpmp/miniupnpc.
teamcity awarded D16563: build: fix mingw miniupnpc cflags a Haypence token.
Fabien added a comment to D16563: build: fix mingw miniupnpc cflags.
@bot guix-linux guix-osx guix-win
teamcity updated the summary of D16563: build: fix mingw miniupnpc cflags.
Fabien requested review of D16563: build: fix mingw miniupnpc cflags.
teamcity awarded D16562: build: miniupnpc 2.2.2 a Haypence token.
Fabien added a comment to D16562: build: miniupnpc 2.2.2.
@bot guix-linux guix-osx guix-win
teamcity updated the summary of D16562: build: miniupnpc 2.2.2.
Fabien requested review of D16562: build: miniupnpc 2.2.2.
tobias_ruck published D16560: [Chronik] Relax plugin height checks at startup for review.
Fabien requested review of D16561: Extract tx pool outside of txorphanage.
teamcity added a comment to D16556: [e.cash] Landing page design updates.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.89.41.69:41001 for the next 60 minutes.
teamcity awarded D16556: [e.cash] Landing page design updates a Piece of Eight token.
bytesofman added a comment to D16556: [e.cash] Landing page design updates.
@bot preview-e.cash
teamcity added a comment to D16508: [chronik] add a block-header endpoint.
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
teamcity added a comment to D16508: [chronik] add a block-header endpoint.
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
PiRK updated the diff for D16526: [chronik] add a block-headers endpoint.
rename API (headers -> block-headers, pb.Header -> pb.BlockHeaders)
Kronkmeister committed rABCc95d61841611: [e.cash] Play animations on mining and staking only once (authored by Kronkmeister).
[e.cash] Play animations on mining and staking only once
PiRK updated the diff for D16508: [chronik] add a block-header endpoint.
fix client.py
PiRK updated the diff for D16508: [chronik] add a block-header endpoint.
use /block-header for the path, BlockHeader for the protobuf message and chronik_block_header.py for the functional test, for consistency with other endpoints and in case we need another type of header in the future
Discussed in private with Tobias.
tobias_ruck committed rABC3d759543a0a9: [Chronik] Use the test framework's CScript in plugins instead of our own version (authored by tobias_ruck).
[Chronik] Use the test framework's CScript in plugins instead of our own version
tobias_ruck retitled D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint from [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoints to [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.
tobias_ruck requested review of D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.
tobias_ruck updated the summary of D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.
tobias_ruck updated the summary of D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.
tobias_ruck updated the summary of D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.
PiRK added inline comments to D16526: [chronik] add a block-headers endpoint.
PiRK updated the diff for D16526: [chronik] add a block-headers endpoint.
hold cs_main while fetching all the headers instead of holding and releasing it for each individual header, to avoid getting an inconsistent chain