Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41384 for the next 60 minutes.

@bot preview-e.cash

ah yeah good point, I was thinking the same, airdrop definitely has some charged energy. Could certainly try some ABs as well

copy edit

Nice. Super noticeable.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41562 for the next 60 minutes.

@bot preview-e.cash

In D16656#377331, @emack wrote:

Are these the equivalent of node_module files for react apps and can be ignored?

Make sure the index has synced in test

string layout

mined_in_block -> block

Rebase and rename gettransactionpool -> gettransactionstatus

Fix a typo and update the summary to better explain the rationale

Rename to gettransactionstatus

version bump

Are these the equivalent of node_module files for react apps and can be ignored?

grep should be grep -r ChronikClientNode src/ otherwise it'll return all the ChronikClientNode references in node_modules

In D16654#377314, @emack wrote:

In D16654#377310, @emack wrote:

Just so I'm understanding this correctly, there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path? But external apps using the chronik-client will right?

In D16654#377310, @emack wrote:

Just so I'm understanding this correctly, there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path? But external apps using the chronik-client will right?

there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path?

Just so I'm understanding this correctly, there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path? But external apps using the chronik-client will right?

updating types from rebase

rebase

In D16645#377217, @tobias_ruck wrote:

Another possible name would be gettransactionstatus; you already say this in the release notes: "retrieve the status of a non-mined transaction". It would (kinda) imply that the RPC should return "mined" for mined txs (which we can't do in the general case because the -txindex can be disabled). So either it looks that up (and returns "unknown" if the txindex is off), or the name could also be gettransactionstatusinmemory, which is I think the most precise, albeit a bit long.

Another possible name would be gettransactionstatus; you already say this in the release notes: "retrieve the status of a non-mined transaction". It would (kinda) imply that the RPC should return "mined" for mined txs (which we can't do in the general case because the -txindex can be disabled). So either it looks that up (and returns "unknown" if the txindex is off), or the name could also be gettransactionstatusinmemory, which is I think the most precise, albeit a bit long.

k -- not sure on the CI failure, but does not appear related to the cosmetic changes in this latest update.

...have not seen this CI failure before and not able to diagnose the cause. re-running to see if it's a previously unseen flakiness. could be related to the rebase.

remove useless comments, remove ref to tests in README, remove "real" server URLs from README

Note I might change the RPC name if I can find a better one