Abuse can me mitigated by asking for an email address or having them take some other kind of higher friction action. It probably won't take long before it's necessary to deal with automated scripts.

Fix the README and remove the confusing FIXME comment

Sum of nits, globally ok

Rebase to master and version bump

note the above teamcity failure was corrected by this step

better comments, update test mock tx for new airdrop amount

Implement XEC airdrops in token-server and Cashtab

Yes, we wanna make sure we don't crash in this scenario. There might be others too, but I hadn't had the time to cover them yet, we might do so in the future and amend this test.

If e.g. a mempool tx would be added before blocks, Chronik would crash under stome circumstances, which is currently not tested.

a little wary about hardcoding the height, seems like this would produce different behavior than previous code (which is saying, take up the whole height of the screen, and if the screen is less than 700px tall -- then take up at least 700px).

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41453 for the next 60 minutes.

@bot preview-e.cash

In D16634#376875, @johnkuney wrote:

lmao the 'lgtm' auto meme posting!? is that custom or built in phab feature haha

I get the logic of "not doing the name change on every app in the monorepo at the same time" -- lets us easily back out diffs from one-app changes. Even with this though, I would rather just rip the bandaid off and get rid of it. Since we only have a handful of apps, and they are all linked to this repo in the monorepo, it's easy enough to test and confirm that the names are all updated in the monorepo.

Fix a typo

Let's update the message with better usability in another diff, that's already an improvement

Updated with on-spec but empty identifier condition

We probably need some comms on this along the lines of:

1. next version is a breaking change for apps using NNG
2. For existing in-node apps, refactor all references to ChronikClientNode to be ChronikClient
3. For existing NNG powered apps, keep in mind changes a, b, c...... e.g. using address.history() going forward instead of script.history()

In D16627#376909, @bytesofman wrote:

In D16627#376897, @Fabien wrote:

Update ecash-herald, token-server, and Cashtab to handle this new type.

Because you aliased ChronikNodeClient this can (and should) be done in subsequent diffs.

Backed out the ChronikClientNode to ChronikClient name change in associated apps -- however some code changes are still required due to changes in the type names.

...These could also be aliasesd but imo not worth it. I don't think keeping a handful of types clean is worth supporting "Everything has two names" for some indefinite period of time.

This change will be caught by linters by anyone who upgrades chronik-client.

beyond the scope of this diff -- but why different lokad id for all of these things that are different functions of ecashchat?

Updated author

beyond the scope of this diff -- but why different lokad id for all of these things that are different functions of ecashchat?

Updated to parse hex article txids and updated off spec messaging

Updated rendered messages

Updated dependency

Updated author and payload labelling

is there any expected byte length here? what makes it unique? what happens if someone starts broadcasting clones of these txs ... there's no way to guarantee this is unique since it is public.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41495 for the next 60 minutes.