Page MenuHomePhabricator
Feed All Stories

Nov 13 2024

bytesofman committed rABC1eb41fa0080d: [Cashtab] Add type deps for ts conversion (authored by bytesofman).
[Cashtab] Add type deps for ts conversion
Nov 13 2024, 03:32
emack accepted D17126: [Cashtab] Add type deps for ts conversion.
Nov 13 2024, 01:50
emack accepted D17123: [Cashtab] Remove redundant spinner from agora screen.
Nov 13 2024, 01:48
bytesofman published D17126: [Cashtab] Add type deps for ts conversion for review.
Nov 13 2024, 01:03
bytesofman closed D17120: [Cashtab] Patch bug in tx parsing to correctly parse agora partial sales.
Nov 13 2024, 01:02
bytesofman committed rABC94a48459cc94: [Cashtab] Patch bug in tx parsing to correctly parse agora partial sales (authored by bytesofman).
[Cashtab] Patch bug in tx parsing to correctly parse agora partial sales
Nov 13 2024, 01:02
bytesofman closed D17119: [ecash-herald] Present daily total volume for agora.
Nov 13 2024, 01:01
bytesofman committed rABC847bb4b29c66: [ecash-herald] Present daily total volume for agora (authored by bytesofman).
[ecash-herald] Present daily total volume for agora
Nov 13 2024, 01:01
bytesofman closed D17118: [ecash-herald] Lint for typescript.
Nov 13 2024, 01:00
bytesofman committed rABC4bc82ca4a111: [ecash-herald] Lint for typescript (authored by bytesofman).
[ecash-herald] Lint for typescript
Nov 13 2024, 01:00
bytesofman requested changes to D17124: [cashtab] Menu style tweaks.

Much better than what we have now, should go in.

Nov 13 2024, 00:54
bytesofman closed D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 13 2024, 00:49
bytesofman committed rABCa4863a710ccf: [Cashtab] Add Collection component to better organize and render NFTs (authored by bytesofman).
[Cashtab] Add Collection component to better organize and render NFTs
Nov 13 2024, 00:49
bytesofman published D17123: [Cashtab] Remove redundant spinner from agora screen for review.
Nov 13 2024, 00:39

Nov 12 2024

emack accepted D17120: [Cashtab] Patch bug in tx parsing to correctly parse agora partial sales.
Nov 12 2024, 23:27
emack accepted D17119: [ecash-herald] Present daily total volume for agora.
Nov 12 2024, 23:11
emack accepted D17118: [ecash-herald] Lint for typescript.
Nov 12 2024, 23:04
emack accepted D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 12 2024, 22:53
johnkuney updated the diff for D17124: [cashtab] Menu style tweaks.

Fix tests, adjust the css its looking for to the max-width value

Nov 12 2024, 22:26
teamcity added a comment to D17124: [cashtab] Menu style tweaks.
Nov 12 2024, 22:15
johnkuney requested review of D17124: [cashtab] Menu style tweaks.
Nov 12 2024, 22:12
bytesofman published D17120: [Cashtab] Patch bug in tx parsing to correctly parse agora partial sales for review.
Nov 12 2024, 21:09
roqqit abandoned D16992: [avalanche] Start populating the staking contender cache.

Split up into separate diffs:
D17027
D17075
D17117
D17121

Nov 12 2024, 21:05
roqqit requested review of D17121: [avalanche] Add stake contender polling.
Nov 12 2024, 21:01
roqqit closed D17117: [avalanche] Add manual stake winners to the contender cache.
Nov 12 2024, 20:56
roqqit committed rABCa69cdc622b76: [avalanche] Add manual stake winners to the contender cache (authored by roqqit).
[avalanche] Add manual stake winners to the contender cache
Nov 12 2024, 20:56
Fabien accepted D17117: [avalanche] Add manual stake winners to the contender cache.
Nov 12 2024, 20:23
bytesofman published D17119: [ecash-herald] Present daily total volume for agora for review.
Nov 12 2024, 19:53
teamcity awarded D17117: [avalanche] Add manual stake winners to the contender cache a Haypence token.
Nov 12 2024, 19:41
Fabien added a comment to D17117: [avalanche] Add manual stake winners to the contender cache.

@bot build-tsan

Nov 12 2024, 19:41
bytesofman published D17118: [ecash-herald] Lint for typescript for review.
Nov 12 2024, 19:15
roqqit requested changes to D17108: net: split CConnman::SocketHandler().
Nov 12 2024, 18:31
roqqit accepted D17107: net: keep reference to each node during socket wait.
Nov 12 2024, 18:25
roqqit accepted D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.
Nov 12 2024, 18:21
roqqit requested review of D17117: [avalanche] Add manual stake winners to the contender cache.
Nov 12 2024, 17:55
PiRK updated the diff for D17108: net: split CConnman::SocketHandler().

add missing lock annotation

Nov 12 2024, 17:27
PiRK updated the diff for D17107: net: keep reference to each node during socket wait.

rebase

Nov 12 2024, 17:25
PiRK updated the diff for D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.

rebase

Nov 12 2024, 17:24
bytesofman closed D17116: [Cashtab] Do not load ONESHOT offers on manage screen for partials.
Nov 12 2024, 17:13
bytesofman committed rABC4db47ba99cdc: [Cashtab] Do not load ONESHOT offers on manage screen for partials (authored by bytesofman).
[Cashtab] Do not load ONESHOT offers on manage screen for partials
Nov 12 2024, 17:13
PiRK closed D17115: test: add option to speed up tx relay/mempool sync.
Nov 12 2024, 16:53
PiRK committed rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync (authored by brunoerg <brunoely.gc@gmail.com>).
test: add option to speed up tx relay/mempool sync
Nov 12 2024, 16:53
Fabien accepted D17115: test: add option to speed up tx relay/mempool sync.
Nov 12 2024, 16:22
PiRK closed D17114: p2p: Allow whitelisting manual connections.
Nov 12 2024, 16:14
PiRK closed D17112: Bump version to 0.30.5.
Nov 12 2024, 16:14
PiRK committed rABC0e905bbfc0af: p2p: Allow whitelisting manual connections (authored by brunoerg <brunoely.gc@gmail.com>).
p2p: Allow whitelisting manual connections
Nov 12 2024, 16:14
PiRK committed rABC337a7020cbc3: Bump version to 0.30.5 (authored by PiRK).
Bump version to 0.30.5
Nov 12 2024, 16:14
PiRK closed D17111: scripted-diff: net: rename permissionFlags to permission_flags.
Nov 12 2024, 16:14
PiRK closed D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 16:14
PiRK committed rABC2986e66378db: scripted-diff: net: rename permissionFlags to permission_flags (authored by PiRK).
scripted-diff: net: rename permissionFlags to permission_flags
Nov 12 2024, 16:14
PiRK committed rABC0211596ef3bb: net: Add CNodeOptions and increase constness (authored by PiRK).
net: Add CNodeOptions and increase constness
Nov 12 2024, 16:14
PiRK closed D17109: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection.
Nov 12 2024, 16:14
PiRK committed rABC5df861c9c822: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection (authored by Luke Dashjr <luke-jr+git@utopios.org>).
net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection
Nov 12 2024, 16:14
PiRK updated the diff for D17115: test: add option to speed up tx relay/mempool sync.

remove comment (x52), include new test from D17113

Nov 12 2024, 16:13
Fabien requested changes to D17115: test: add option to speed up tx relay/mempool sync.
Nov 12 2024, 15:41
Fabien added a comment to D17115: test: add option to speed up tx relay/mempool sync.

please include the mining_getblocktemplate_longpoll.py from D17113

Nov 12 2024, 15:40
Fabien accepted D17114: p2p: Allow whitelisting manual connections.
Nov 12 2024, 15:39
Fabien accepted D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 15:38
Fabien closed D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Nov 12 2024, 15:26
Fabien committed rABC88af2bfac785: Improve test coverage of the getblocktemplate longpoll feature with avalanche (authored by Fabien).
Improve test coverage of the getblocktemplate longpoll feature with avalanche
Nov 12 2024, 15:26
Fabien added inline comments to D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Nov 12 2024, 15:26
PiRK accepted D17116: [Cashtab] Do not load ONESHOT offers on manage screen for partials.
Nov 12 2024, 15:16
PiRK accepted D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Nov 12 2024, 15:15
PiRK added inline comments to D17115: test: add option to speed up tx relay/mempool sync.
Nov 12 2024, 15:07
PiRK updated the diff for D17115: test: add option to speed up tx relay/mempool sync.

add more tests (mostly abc*). Note that the new way of setting the option is persistent accross node restarts. abc_p2p_avalanche_proof_voting is an example that fails if we set this attribute, because it needs to restart without the noban permission in one of the subtests.

Nov 12 2024, 15:05
PiRK updated the diff for D17114: p2p: Allow whitelisting manual connections.

feedback

Nov 12 2024, 14:55
PiRK requested review of D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 14:52
bytesofman published D17116: [Cashtab] Do not load ONESHOT offers on manage screen for partials for review.
Nov 12 2024, 14:52
PiRK updated the summary of D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 14:52
PiRK added a comment to D17110: net: Add CNodeOptions and increase constness.

The commits are not the correct ones

Nov 12 2024, 14:51
Fabien requested changes to D17115: test: add option to speed up tx relay/mempool sync.

You should go through the abc tests also. I use this a lot to speed up proof relay in tests

Nov 12 2024, 14:41
Fabien requested changes to D17114: p2p: Allow whitelisting manual connections.
Nov 12 2024, 14:39
PiRK added a comment to D17115: test: add option to speed up tx relay/mempool sync.

interface_rest.py | ✓ Passed | 21 s

Nov 12 2024, 14:30
teamcity updated the summary of D17115: test: add option to speed up tx relay/mempool sync.
Nov 12 2024, 14:28
PiRK requested review of D17115: test: add option to speed up tx relay/mempool sync.
Nov 12 2024, 14:28
teamcity updated the summary of D17114: p2p: Allow whitelisting manual connections.
Nov 12 2024, 14:25
PiRK requested review of D17114: p2p: Allow whitelisting manual connections.
Nov 12 2024, 14:25
Fabien accepted D17112: Bump version to 0.30.5.
Nov 12 2024, 14:06
Fabien accepted D17111: scripted-diff: net: rename permissionFlags to permission_flags.
Nov 12 2024, 14:05
bytesofman requested review of D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 12 2024, 14:05
Fabien requested changes to D17110: net: Add CNodeOptions and increase constness.

The commits are not the correct ones

Nov 12 2024, 14:02
Fabien accepted D17109: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection.
Nov 12 2024, 13:53
Fabien requested review of D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Nov 12 2024, 13:41
PiRK requested review of D17112: Bump version to 0.30.5.
Nov 12 2024, 13:30
PiRK added inline comments to D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 13:19
teamcity updated the summary of D17111: scripted-diff: net: rename permissionFlags to permission_flags.
Nov 12 2024, 13:17
PiRK requested review of D17111: scripted-diff: net: rename permissionFlags to permission_flags.
Nov 12 2024, 13:17
teamcity updated the summary of D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 13:16
PiRK requested review of D17110: net: Add CNodeOptions and increase constness.
Nov 12 2024, 13:16
teamcity updated the summary of D17109: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection.
Nov 12 2024, 11:34
PiRK requested review of D17109: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection.
Nov 12 2024, 11:34
PiRK added a comment to D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.

I'm not able to reproduce the failure in 100 runs of the test , but I noticed that the test duration variability is wild, with values ranging from 6s to 41s.
I will backport 27114 to hopefully speed this up.

Nov 12 2024, 10:04

Nov 11 2024

PiRK planned changes to D17108: net: split CConnman::SocketHandler().

lock issue or lock annotation issue to be investigated

Nov 11 2024, 19:23
PiRK planned changes to D17107: net: keep reference to each node during socket wait.
Nov 11 2024, 19:22
PiRK planned changes to D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.

functional test failure to be investigated

Nov 11 2024, 19:21
teamcity added a comment to D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.
Nov 11 2024, 19:12
teamcity added a comment to D17108: net: split CConnman::SocketHandler().
Nov 11 2024, 19:10
teamcity added a comment to D17108: net: split CConnman::SocketHandler().
Nov 11 2024, 19:09
teamcity updated the summary of D17108: net: split CConnman::SocketHandler().
Nov 11 2024, 19:04
PiRK requested review of D17108: net: split CConnman::SocketHandler().
Nov 11 2024, 19:04