Page MenuHomePhabricator
Feed Advanced Search

Dec 17 2024

roqqit requested review of D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
Dec 17 2024, 22:35
roqqit closed D17349: [seeder] Bump thread stacksize.
Dec 17 2024, 21:02
roqqit committed rABC61b79c87cb21: [seeder] Bump thread stacksize (authored by roqqit).
[seeder] Bump thread stacksize
Dec 17 2024, 21:02
roqqit retitled D17349: [seeder] Bump thread stacksize from [seeder] Respect resource limit for stacksize as set by the system to [seeder] Bump thread stacksize.
Dec 17 2024, 20:38
roqqit updated the diff for D17349: [seeder] Bump thread stacksize.

Just bump the value because predicting it is proving to be difficult and time consuming

Dec 17 2024, 20:37

Dec 16 2024

roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
Dec 16 2024, 18:20
roqqit updated the diff for D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.

Use a debug RPC. Waiting for getavalanchepeerinfo is not sufficient here because its possible for this value to be updated before the contender is added to the cache.

Dec 16 2024, 17:49

Dec 13 2024

roqqit closed D17348: [seeder] Return an error when thread creation fails.
Dec 13 2024, 21:06
roqqit committed rABC200513e58adb: [seeder] Return an error when thread creation fails (authored by roqqit).
[seeder] Return an error when thread creation fails
Dec 13 2024, 21:06
roqqit closed D17350: [seeder] Reword outdated note in readme.
Dec 13 2024, 21:05
roqqit committed rABC82d1ab6e576c: [seeder] Reword outdated note in readme (authored by roqqit).
[seeder] Reword outdated note in readme
Dec 13 2024, 21:05
roqqit requested review of D17350: [seeder] Reword outdated note in readme.
Dec 13 2024, 20:43
roqqit requested review of D17348: [seeder] Return an error when thread creation fails.
Dec 13 2024, 20:27
roqqit requested review of D17349: [seeder] Bump thread stacksize.
Dec 13 2024, 20:27
roqqit updated the test plan for D17349: [seeder] Bump thread stacksize.
Dec 13 2024, 20:26
roqqit planned changes to D17348: [seeder] Return an error when thread creation fails.
Dec 13 2024, 20:08
roqqit planned changes to D17349: [seeder] Bump thread stacksize.
Dec 13 2024, 20:08
roqqit requested review of D17349: [seeder] Bump thread stacksize.
Dec 13 2024, 20:08
roqqit requested review of D17348: [seeder] Return an error when thread creation fails.
Dec 13 2024, 19:37

Dec 12 2024

roqqit requested review of D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Dec 12 2024, 22:08
roqqit accepted D17343: [CI] Fix a type in the build configuration file.
Dec 12 2024, 20:36
roqqit accepted D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Dec 12 2024, 20:18
roqqit closed D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Dec 12 2024, 17:34
roqqit committed rABC44da17657e7c: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup (authored by roqqit).
[avalanche] Restrict scope of cs_stakingRewards lock during cleanup
Dec 12 2024, 17:34

Dec 11 2024

roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
Dec 11 2024, 23:43
roqqit requested review of D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Dec 11 2024, 17:48

Dec 10 2024

roqqit closed D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 19:57
roqqit committed rABCe9d7a6220c01: Add symlink to most recent functional test failure directory (authored by roqqit).
Add symlink to most recent functional test failure directory
Dec 10 2024, 19:57
roqqit closed D17330: Run more functional tests in parallel by default.
Dec 10 2024, 18:08
roqqit committed rABC8917a6f8af6c: Run more functional tests in parallel by default (authored by roqqit).
Run more functional tests in parallel by default
Dec 10 2024, 18:08
roqqit updated the test plan for D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 17:36
roqqit updated the diff for D17331: Add symlink to most recent functional test failure directory.
  • move lastfailure to top of build_dir
  • ignore OSError exceptions on windows (didn't use contextlib.suppress because I don't think we should ignore it on Linux)
Dec 10 2024, 17:36
roqqit planned changes to D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 16:51
roqqit closed D17329: Remove incorrect note in functional tests doc.
Dec 10 2024, 16:48
roqqit committed rABCaeee696108b5: Remove incorrect note in functional tests doc (authored by roqqit).
Remove incorrect note in functional tests doc
Dec 10 2024, 16:48
roqqit added a comment to D17330: Run more functional tests in parallel by default.
In D17330#393720, @PiRK wrote:

Benchmark on my machine:

DEFAULT_JOBS =  (multiprocessing.cpu_count() // 3) + 1
ALL                                        | ✓ Passed  | 1603 s (accumulated)
Runtime: 179 s


DEFAULT_JOBS = multiprocessing.cpu_count()
ALL                                        | ✓ Passed  | 2187 s (accumulated)
Runtime: 95 s

DEFAULT_JOBS = 2 * multiprocessing.cpu_count()
ALL                                        | ✖ Failed  | 2583 s (accumulated)
Runtime: 68 s

With one port issue in the 2 * cpu_count attempt.

RuntimeError: Could not find available PortName.P2P port after 5 attempts.
Dec 10 2024, 16:47
roqqit requested review of D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 00:51

Dec 9 2024

roqqit requested review of D17330: Run more functional tests in parallel by default.
Dec 9 2024, 22:47
roqqit requested review of D17329: Remove incorrect note in functional tests doc.
Dec 9 2024, 21:54
roqqit closed D17327: Use os.cpu_count in test_runner instead of multiprocessing.
Dec 9 2024, 21:12
roqqit committed rABCe0198d8be5cd: Use os.cpu_count in test_runner instead of multiprocessing (authored by roqqit).
Use os.cpu_count in test_runner instead of multiprocessing
Dec 9 2024, 21:12
roqqit requested review of D17327: Use os.cpu_count in test_runner instead of multiprocessing.
Dec 9 2024, 19:43
roqqit closed D17306: [avalanche] Ensure every connected block has staking rewards computed.
Dec 9 2024, 17:17
roqqit committed rABC7a92d503f674: [avalanche] Ensure every connected block has staking rewards computed (authored by roqqit).
[avalanche] Ensure every connected block has staking rewards computed
Dec 9 2024, 17:17

Dec 6 2024

roqqit updated the diff for D17306: [avalanche] Ensure every connected block has staking rewards computed.

feedback

Dec 6 2024, 21:23
roqqit accepted D17303: build: Bump libevent minimum version up to 2.1.8.
Dec 6 2024, 18:36
roqqit updated the diff for D17306: [avalanche] Ensure every connected block has staking rewards computed.

fix potential deadlock

Dec 6 2024, 16:46
roqqit planned changes to D17306: [avalanche] Ensure every connected block has staking rewards computed.
Dec 6 2024, 16:27
roqqit requested review of D17306: [avalanche] Ensure every connected block has staking rewards computed.
Dec 6 2024, 15:13

Dec 4 2024

roqqit closed D17287: Remove executable file mode from some functional tests.
Dec 4 2024, 18:41
roqqit committed rABC518391383004: Remove executable file mode from some functional tests (authored by roqqit).
Remove executable file mode from some functional tests
Dec 4 2024, 18:41

Dec 3 2024

roqqit updated the diff for D17287: Remove executable file mode from some functional tests.

cleanup shebangs to make lint happy

Dec 3 2024, 18:19
roqqit requested review of D17287: Remove executable file mode from some functional tests.
Dec 3 2024, 18:16

Nov 25 2024

roqqit closed D17189: [avalanche] Fix getdata log not showing stake contender inv type name.
Nov 25 2024, 16:43
roqqit committed rABC44ea0e528faf: [avalanche] Fix getdata log not showing stake contender inv type name (authored by roqqit).
[avalanche] Fix getdata log not showing stake contender inv type name
Nov 25 2024, 16:43

Nov 22 2024

roqqit closed D17190: [avalanche] Remove redundant code to ignore stake contender getdata requests.
Nov 22 2024, 20:39
roqqit committed rABC2c80192da9a5: [avalanche] Remove redundant code to ignore stake contender getdata requests (authored by roqqit).
[avalanche] Remove redundant code to ignore stake contender getdata requests
Nov 22 2024, 20:39
roqqit requested review of D17190: [avalanche] Remove redundant code to ignore stake contender getdata requests.
Nov 22 2024, 18:52
roqqit requested review of D17189: [avalanche] Fix getdata log not showing stake contender inv type name.
Nov 22 2024, 18:30

Nov 21 2024

roqqit closed D17171: [avalanche] Cleanup redundant check for avalanche processor.
Nov 21 2024, 16:51
roqqit committed rABC078a6c85e1e9: [avalanche] Cleanup redundant check for avalanche processor (authored by roqqit).
[avalanche] Cleanup redundant check for avalanche processor
Nov 21 2024, 16:51
suthem-969 awarded rABC59076f7b8f83: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test a Love token.
Nov 21 2024, 15:39 · Restricted Project
suthem-969 awarded D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test a 100 token.
Nov 21 2024, 15:00

Nov 20 2024

roqqit requested review of D17171: [avalanche] Cleanup redundant check for avalanche processor.
Nov 20 2024, 21:54
roqqit closed D17163: [avalanche] Do not modify the chaintip in stake contender test.
Nov 20 2024, 17:51
roqqit committed rABCd74a3bd8a0e8: [avalanche] Do not modify the chaintip in stake contender test (authored by roqqit).
[avalanche] Do not modify the chaintip in stake contender test
Nov 20 2024, 17:51

Nov 19 2024

teamcity awarded D17163: [avalanche] Do not modify the chaintip in stake contender test a Piece of Eight token.
Nov 19 2024, 21:24
roqqit added a comment to D17163: [avalanche] Do not modify the chaintip in stake contender test.

@bot build-tsan

Nov 19 2024, 21:24
roqqit updated the diff for D17163: [avalanche] Do not modify the chaintip in stake contender test.

Better approach

Nov 19 2024, 21:23
roqqit retitled D17163: [avalanche] Do not modify the chaintip in stake contender test from [avalanche] Add missing lock in stake contenders test to [avalanche] Do not modify the chaintip in stake contender test.
Nov 19 2024, 21:23
teamcity awarded D17163: [avalanche] Do not modify the chaintip in stake contender test a Haypence token.
Nov 19 2024, 21:09
roqqit added a comment to D17163: [avalanche] Do not modify the chaintip in stake contender test.

@bot build-tsan

Nov 19 2024, 21:09
roqqit requested review of D17163: [avalanche] Do not modify the chaintip in stake contender test.
Nov 19 2024, 21:08

Nov 18 2024

roqqit closed D17121: [avalanche] Add stake contender polling.
Nov 18 2024, 21:47
roqqit committed rABC3b44e6192850: [avalanche] Add stake contender polling (authored by roqqit).
[avalanche] Add stake contender polling
Nov 18 2024, 21:47
roqqit closed D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.
Nov 18 2024, 21:46
roqqit committed rABC59076f7b8f83: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test (authored by roqqit).
[avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test
Nov 18 2024, 21:46 · Restricted Project
roqqit closed D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.
Nov 18 2024, 21:45
roqqit committed rABCea1205ddb23a: [avalanche] Return pending stake contender status when there is no local… (authored by roqqit).
[avalanche] Return pending stake contender status when there is no local…
Nov 18 2024, 21:45
roqqit updated the diff for D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.

Added back an invalid case. It is incomplete since the local winner does not actually trigger an ACCEPT vote, but this should make it more obvious where that test is heading.

Nov 18 2024, 18:33
roqqit requested review of D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.
Nov 18 2024, 18:28
roqqit accepted D17159: util: optimize HexStr.
Nov 18 2024, 17:42
roqqit accepted D17158: Handle invalid hex encoding in ParseHex.
Nov 18 2024, 17:22
roqqit accepted D17157: util: Add ParseHex<std::byte>() helper.
Nov 18 2024, 17:16
roqqit accepted D17156: refactor: Take Span in SetSeed.
Nov 18 2024, 17:06

Nov 15 2024

roqqit updated the summary of D17121: [avalanche] Add stake contender polling.
Nov 15 2024, 18:14
roqqit updated the diff for D17121: [avalanche] Add stake contender polling.

rebase on D17144 to fix early convergence issue

Nov 15 2024, 18:13
roqqit requested review of D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.
Nov 15 2024, 18:11

Nov 14 2024

roqqit accepted D17130: refactor: wrap accept() and extend usage of Sock.
Nov 14 2024, 21:48

Nov 13 2024

roqqit accepted D17130: refactor: wrap accept() and extend usage of Sock.
Nov 13 2024, 21:21
roqqit updated the diff for D17121: [avalanche] Add stake contender polling.
  • set mock time and give some comments why we do this
  • clarify a bunch of comments in the goofy loop
Nov 13 2024, 20:59
roqqit accepted D17108: net: split CConnman::SocketHandler().
Nov 13 2024, 16:47

Nov 12 2024

roqqit abandoned D16992: [avalanche] Start populating the staking contender cache.

Split up into separate diffs:
D17027
D17075
D17117
D17121

Nov 12 2024, 21:05
roqqit requested review of D17121: [avalanche] Add stake contender polling.
Nov 12 2024, 21:01
roqqit closed D17117: [avalanche] Add manual stake winners to the contender cache.
Nov 12 2024, 20:56
roqqit committed rABCa69cdc622b76: [avalanche] Add manual stake winners to the contender cache (authored by roqqit).
[avalanche] Add manual stake winners to the contender cache
Nov 12 2024, 20:56
teamcity awarded D17117: [avalanche] Add manual stake winners to the contender cache a Haypence token.
Nov 12 2024, 19:41
roqqit requested changes to D17108: net: split CConnman::SocketHandler().
Nov 12 2024, 18:31
roqqit accepted D17107: net: keep reference to each node during socket wait.
Nov 12 2024, 18:25
roqqit accepted D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.
Nov 12 2024, 18:21