Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Fri, Apr 11

roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Fri, Apr 11, 15:41
roqqit closed D17923: [avalanche] Wait for the local winner instead of immediately asserting.
Fri, Apr 11, 15:25
roqqit committed rABCc50432fcd1a8: [avalanche] Wait for the local winner instead of immediately asserting (authored by roqqit).
[avalanche] Wait for the local winner instead of immediately asserting
Fri, Apr 11, 15:25

Thu, Apr 10

roqqit requested review of D17923: [avalanche] Wait for the local winner instead of immediately asserting.
Thu, Apr 10, 23:41
roqqit closed D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Thu, Apr 10, 21:21
roqqit committed rABCe0776c77fd38: [avalanche] Remove requirement that local staking rewards have to be computed… (authored by roqqit).
[avalanche] Remove requirement that local staking rewards have to be computed…
Thu, Apr 10, 21:21
roqqit accepted D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 21:15
roqqit added inline comments to D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Thu, Apr 10, 18:04

Wed, Apr 9

roqqit requested review of D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.
Wed, Apr 9, 22:22
roqqit accepted D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Wed, Apr 9, 16:37
roqqit accepted D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
Wed, Apr 9, 16:34
roqqit closed D17912: Add Shibusawa activation logic.
Wed, Apr 9, 15:43
roqqit committed rABC8b148e37eb56: Add Shibusawa activation logic (authored by roqqit).
Add Shibusawa activation logic
Wed, Apr 9, 15:43

Tue, Apr 8

roqqit requested review of D17912: Add Shibusawa activation logic.
Tue, Apr 8, 18:52
roqqit accepted D17911: test: Introduce ensure_for helper.
Tue, Apr 8, 15:37

Mon, Apr 7

roqqit closed D17905: [avalanche] Add debug logging when local contenders are set.
Mon, Apr 7, 17:14
roqqit committed rABCb0a72edbe957: [avalanche] Add debug logging when local contenders are set (authored by roqqit).
[avalanche] Add debug logging when local contenders are set
Mon, Apr 7, 17:14
roqqit updated the diff for D17905: [avalanche] Add debug logging when local contenders are set.

Add block height

Mon, Apr 7, 16:59
roqqit requested review of D17905: [avalanche] Add debug logging when local contenders are set.
Mon, Apr 7, 16:04

Thu, Apr 3

roqqit accepted D17890: validation: pass ChainstateRole for validationinterface calls.
Thu, Apr 3, 21:49
roqqit accepted D17892: net_processing: validationinterface: ignore some events for bg chain.
Thu, Apr 3, 17:39
roqqit accepted D17891: validationinterface: only send zmq notifications for active.
Thu, Apr 3, 17:34
roqqit requested changes to D17890: validation: pass ChainstateRole for validationinterface calls.
Thu, Apr 3, 17:29
roqqit updated the summary of D17890: validation: pass ChainstateRole for validationinterface calls.
Thu, Apr 3, 17:05
roqqit accepted D17889: validation: only call UpdatedBlockTip for active chainstate.
Thu, Apr 3, 17:03
roqqit accepted D17888: validation: MaybeRebalanceCaches when chain leaves IBD.
Thu, Apr 3, 17:02

Wed, Apr 2

roqqit committed rABCee751ff92ab4: [avalanche] Cleanup unnecessary API passthrough of getWinners (authored by roqqit).
[avalanche] Cleanup unnecessary API passthrough of getWinners
Wed, Apr 2, 23:46
roqqit closed D17882: [avalanche] Cleanup unnecessary API passthrough of getWinners.
Wed, Apr 2, 23:46
roqqit closed D17881: [avalanche] Clarify separation of responsibilities for setting local winner contender statuses.
Wed, Apr 2, 23:44
roqqit committed rABCde65c9fdd05b: [avalanche] Clarify separation of responsibilities for setting local winner… (authored by roqqit).
[avalanche] Clarify separation of responsibilities for setting local winner…
Wed, Apr 2, 23:44
roqqit closed D17880: [avalanche] Cleanup unused addStakeContender in Processor.
Wed, Apr 2, 23:41
roqqit committed rABCff86651f6506: [avalanche] Cleanup unused addStakeContender in Processor (authored by roqqit).
[avalanche] Cleanup unused addStakeContender in Processor
Wed, Apr 2, 23:41
roqqit closed D17879: [avalanche] Add test coverage to ensure immature proofs are handled correctly as contenders.
Wed, Apr 2, 23:40
roqqit committed rABCa17bb89fa414: [avalanche] Add test coverage to ensure immature proofs are handled correctly… (authored by roqqit).
[avalanche] Add test coverage to ensure immature proofs are handled correctly…
Wed, Apr 2, 23:40
roqqit requested review of D17882: [avalanche] Cleanup unnecessary API passthrough of getWinners.
Wed, Apr 2, 18:53
roqqit requested review of D17881: [avalanche] Clarify separation of responsibilities for setting local winner contender statuses.
Wed, Apr 2, 18:49
roqqit requested review of D17880: [avalanche] Cleanup unused addStakeContender in Processor.
Wed, Apr 2, 16:19
roqqit requested review of D17879: [avalanche] Add test coverage to ensure immature proofs are handled correctly as contenders.
Wed, Apr 2, 16:01

Mon, Mar 31

roqqit closed D17867: [avalanche] Add stake contenders to the cache every time a proof is registered.
Mon, Mar 31, 15:18
roqqit committed rABC09cc323fb712: [avalanche] Add stake contenders to the cache every time a proof is registered (authored by roqqit).
[avalanche] Add stake contenders to the cache every time a proof is registered
Mon, Mar 31, 15:18

Thu, Mar 27

roqqit accepted D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Thu, Mar 27, 21:30
roqqit requested review of D17867: [avalanche] Add stake contenders to the cache every time a proof is registered.
Thu, Mar 27, 21:10
roqqit closed D17861: [avalanche] Make sure to only promote contenders once for each proofid.
Thu, Mar 27, 18:00
roqqit committed rABCaff18f3253ee: [avalanche] Make sure to only promote contenders once for each proofid (authored by roqqit).
[avalanche] Make sure to only promote contenders once for each proofid
Thu, Mar 27, 18:00
roqqit closed D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Thu, Mar 27, 18:00
roqqit committed rABC6fb44405d40d: [avalanche] Add some logging when stake contenders are cached or promoted (authored by roqqit).
[avalanche] Add some logging when stake contenders are cached or promoted
Thu, Mar 27, 18:00
roqqit accepted D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 16:58
roqqit updated the diff for D17861: [avalanche] Make sure to only promote contenders once for each proofid.

remove the set because it is not really needed

Thu, Mar 27, 16:50
roqqit updated the diff for D17860: [avalanche] Add some logging when stake contenders are cached or promoted.

feedback

Thu, Mar 27, 16:41

Wed, Mar 26

roqqit updated the test plan for D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Wed, Mar 26, 23:12
roqqit requested review of D17861: [avalanche] Make sure to only promote contenders once for each proofid.
Wed, Mar 26, 23:12
roqqit requested review of D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Wed, Mar 26, 22:55

Fri, Mar 21

roqqit closed D17840: [avalanche] Fix flaky proof rank comparison in processor_tests.
Fri, Mar 21, 14:54
roqqit committed rABC4271d8338029: [avalanche] Fix flaky proof rank comparison in processor_tests (authored by roqqit).
[avalanche] Fix flaky proof rank comparison in processor_tests
Fri, Mar 21, 14:54

Thu, Mar 20

roqqit requested changes to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Thu, Mar 20, 17:25
roqqit closed D17834: [avalanche] Refactor helpers to build avaproofs messages.
Thu, Mar 20, 17:06
roqqit committed rABC892275701a2b: [avalanche] Refactor helpers to build avaproofs messages (authored by roqqit).
[avalanche] Refactor helpers to build avaproofs messages
Thu, Mar 20, 17:06
roqqit committed rABC2b95ae7e2f43: [avalanche] Cleanup unused prefilled proof index set (authored by roqqit).
[avalanche] Cleanup unused prefilled proof index set
Thu, Mar 20, 17:04
roqqit closed D17833: [avalanche] Cleanup unused prefilled proof index set.
Thu, Mar 20, 17:04
roqqit requested review of D17840: [avalanche] Fix flaky proof rank comparison in processor_tests.
Thu, Mar 20, 17:04

Wed, Mar 19

roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.

back to you

Wed, Mar 19, 22:56
roqqit accepted D17829: [avalanche] Add to the recently finalized items filter at callsite.

This looks a bit odd to move it to the callsite but since it is moving in the right direction with regards to the processor FIXME, it is probably a small step in the right direction.

Wed, Mar 19, 22:53
roqqit requested review of D17834: [avalanche] Refactor helpers to build avaproofs messages.
Wed, Mar 19, 22:48
roqqit requested review of D17833: [avalanche] Cleanup unused prefilled proof index set.
Wed, Mar 19, 21:44

Tue, Mar 18

roqqit committed rABCf7b0bdf7c762: [electrum] Fix typo in trezor firmware warning text (authored by roqqit).
[electrum] Fix typo in trezor firmware warning text
Tue, Mar 18, 16:31
roqqit closed D17818: [electrum] Fix typo in trezor firmware warning text.
Tue, Mar 18, 16:31
roqqit requested review of D17818: [electrum] Fix typo in trezor firmware warning text.
Tue, Mar 18, 15:52
roqqit accepted D17817: [avalanche] Improve performance of inventory filtering.
Tue, Mar 18, 15:46

Mon, Mar 17

roqqit closed D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 22:10
roqqit committed rABCcf38f5e5d94a: [avalanche] Cleanup circular dependency between peer manager and contender cache (authored by roqqit).
[avalanche] Cleanup circular dependency between peer manager and contender cache
Mon, Mar 17, 22:10
roqqit requested review of D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 19:44

Mar 14 2025

roqqit closed D17788: [avalanche] Move contender cache to peer manager.
Mar 14 2025, 20:40
roqqit committed rABC821580a6ab15: [avalanche] Move contender cache to peer manager (authored by roqqit).
[avalanche] Move contender cache to peer manager
Mar 14 2025, 20:40

Mar 13 2025

roqqit updated the diff for D17788: [avalanche] Move contender cache to peer manager.
  • add lint exception for circular dependency
  • fix lock annotations
Mar 13 2025, 18:07
roqqit accepted D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Mar 13 2025, 17:57
roqqit accepted D17802: [Cashtab] Correct issue of two tests with the same name.
Mar 13 2025, 17:56

Mar 12 2025

roqqit planned changes to D17788: [avalanche] Move contender cache to peer manager.
Mar 12 2025, 19:39
roqqit requested review of D17788: [avalanche] Move contender cache to peer manager.
Mar 12 2025, 19:26

Mar 4 2025

roqqit accepted D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Mar 4 2025, 16:55

Mar 3 2025

roqqit closed D17728: [avalanche] Down-rank rejected contenders.
Mar 3 2025, 20:00
roqqit committed rABC601acac03dc6: [avalanche] Down-rank rejected contenders (authored by roqqit).
[avalanche] Down-rank rejected contenders
Mar 3 2025, 20:00
roqqit closed D17737: [avalanche] Fix a race in contenders voting test (again).
Mar 3 2025, 19:59
roqqit committed rABC489c9cfea31a: [avalanche] Fix a race in contenders voting test (again) (authored by roqqit).
[avalanche] Fix a race in contenders voting test (again)
Mar 3 2025, 19:59
roqqit updated the diff for D17728: [avalanche] Down-rank rejected contenders.

feedback

Mar 3 2025, 17:43
roqqit closed D17700: [avalanche] Process responses to stake contender polls.
Mar 3 2025, 17:11
roqqit committed rABCd25b7436bca1: [avalanche] Process responses to stake contender polls (authored by roqqit).
[avalanche] Process responses to stake contender polls
Mar 3 2025, 17:11
roqqit requested review of D17737: [avalanche] Fix a race in contenders voting test (again).
Mar 3 2025, 16:57

Feb 28 2025

roqqit closed D17729: [avalanche] Fix a race in contenders voting test.
Feb 28 2025, 21:45
roqqit committed rABCd029363ecc33: [avalanche] Fix a race in contenders voting test (authored by roqqit).
[avalanche] Fix a race in contenders voting test
Feb 28 2025, 21:45
roqqit accepted D17730: tests: use noban_tx_relay in more tests.
Feb 28 2025, 21:22
roqqit requested review of D17729: [avalanche] Fix a race in contenders voting test.
Feb 28 2025, 21:15
roqqit accepted D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.

reviewer note: the call to CustomInit() got added to BaseIndex::Start() in one commit and removed in the other. it makes comparing each to this patch a bit weird.

Feb 28 2025, 18:47
roqqit accepted D17721: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function.
Feb 28 2025, 18:33
roqqit accepted D17717: [avalanche] Also finalize the ancestors of a transaction.

re: the note at the end of the summary: when you write this other diff, be sure to include test coverage that attempt to poll finalized ancestors. there is risk of regression here otherwise.

Feb 28 2025, 18:29
roqqit added inline comments to D17700: [avalanche] Process responses to stake contender polls.
Feb 28 2025, 18:22
roqqit requested review of D17728: [avalanche] Down-rank rejected contenders.
Feb 28 2025, 18:21
roqqit added inline comments to D17700: [avalanche] Process responses to stake contender polls.
Feb 28 2025, 18:18
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.
  • use proofid as int in more places
  • check stake winner order
  • fix comment
Feb 28 2025, 17:15

Feb 27 2025

roqqit abandoned D17582: [avalanche] Add an invalidation latch to contender cache.

no longer needed since D17710

Feb 27 2025, 21:27
roqqit closed D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 27 2025, 21:25
Next