Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Fri, Apr 11

PiRK updated the summary of D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 13:05
PiRK updated the diff for D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.

include <functional>

Fri, Apr 11, 13:00
PiRK requested review of D17925: rpc: Make pruneheight also reflect undo data presence.
Fri, Apr 11, 12:58
PiRK requested review of D17924: refactor, blockstorage: Generalize GetFirstStoredBlock.
Fri, Apr 11, 12:53
PiRK closed D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
Fri, Apr 11, 09:02
PiRK closed D17921: rpc: Enable wallet import on pruned nodes.
Fri, Apr 11, 09:02
PiRK committed rABC073ac4d70ec0: test: add coverage for rpc error when trying to rescan beyond pruned data (authored by brunoerg <brunoely.gc@gmail.com>).
test: add coverage for rpc error when trying to rescan beyond pruned data
Fri, Apr 11, 09:02
PiRK committed rABCa6ef9e78d417: test: run feature_pruning.py without wallet compiled (authored by PiRK).
test: run feature_pruning.py without wallet compiled
Fri, Apr 11, 09:02
PiRK closed D17920: test: run feature_pruning.py without wallet compiled.
Fri, Apr 11, 09:02
PiRK committed rABC302a7e7f9443: rpc: Enable wallet import on pruned nodes (authored by Aurèle Oulès <aurele@oules.com>).
rpc: Enable wallet import on pruned nodes
Fri, Apr 11, 09:02
PiRK committed rABCa1687cb9c668: test: stop node before calling assert_start_raises_init_error (authored by Martin Zumsande <mzumsande@gmail.com>).
test: stop node before calling assert_start_raises_init_error
Fri, Apr 11, 09:01
PiRK closed D17919: test: stop node before calling assert_start_raises_init_error.
Fri, Apr 11, 09:01
PiRK accepted D17923: [avalanche] Wait for the local winner instead of immediately asserting.
Fri, Apr 11, 06:56

Thu, Apr 10

PiRK closed D17918: wallet: validationinterface: only handle active chain notifications.
Thu, Apr 10, 21:55
PiRK committed rABC845f8476e440: wallet: validationinterface: only handle active chain notifications (authored by James O'Beirne <james.obeirne@pm.me>).
wallet: validationinterface: only handle active chain notifications
Thu, Apr 10, 21:55
PiRK requested review of D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
Thu, Apr 10, 21:35
PiRK updated the diff for D17921: rpc: Enable wallet import on pruned nodes.

we need to specify the block version in feature_pruning as well (missing backport that specifies version 4 as the default in create_block)

Thu, Apr 10, 21:32
PiRK requested review of D17921: rpc: Enable wallet import on pruned nodes.
Thu, Apr 10, 20:59
PiRK updated the test plan for D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 20:58
PiRK requested review of D17920: test: run feature_pruning.py without wallet compiled.
Thu, Apr 10, 20:00
PiRK requested review of D17919: test: stop node before calling assert_start_raises_init_error.
Thu, Apr 10, 19:55
teamcity awarded D17918: wallet: validationinterface: only handle active chain notifications a Haypence token.
Thu, Apr 10, 13:04
PiRK updated the diff for D17918: wallet: validationinterface: only handle active chain notifications.

remove debugging print

Thu, Apr 10, 13:02
PiRK requested review of D17918: wallet: validationinterface: only handle active chain notifications.
Thu, Apr 10, 12:57

Wed, Apr 9

PiRK accepted D17912: Add Shibusawa activation logic.

it looks good to me. You could also remove the "-schumpeteractivationtime" stuff, it looks like now it is no longer used outside of tests

Wed, Apr 9, 08:49
PiRK closed D17911: test: Introduce ensure_for helper.
Wed, Apr 9, 08:46
PiRK committed rABCf881f585a838: test: Introduce ensure_for helper (authored by Fabian Jahr <fjahr@protonmail.com>).
test: Introduce ensure_for helper
Wed, Apr 9, 08:46

Tue, Apr 8

PiRK requested review of D17911: test: Introduce ensure_for helper.
Tue, Apr 8, 13:49
PiRK accepted D17910: [chronik] Improve connection of the electrum interface test.
Tue, Apr 8, 12:43
PiRK committed rABC41543b6f550c: wallet: Write best block to disk before backup (authored by Fabian Jahr <fjahr@protonmail.com>).
wallet: Write best block to disk before backup
Tue, Apr 8, 10:31
PiRK closed D17907: wallet: Write best block to disk before backup.
Tue, Apr 8, 10:31
PiRK closed D17906: indexes, refactor: Remove CChainState use in index CommitInternal method.
Tue, Apr 8, 10:31
PiRK committed rABC5b3e01c2c387: indexes, refactor: Remove CChainState use in index CommitInternal method (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CChainState use in index CommitInternal method
Tue, Apr 8, 10:31
PiRK accepted D17909: Remove the deprecated address_type field from the getnewaddress RPC.
Tue, Apr 8, 10:30
PiRK accepted D17908: Bump version to 0.31.1.
Tue, Apr 8, 10:27
PiRK updated the summary of D17907: wallet: Write best block to disk before backup.
Tue, Apr 8, 08:10
PiRK requested review of D17907: wallet: Write best block to disk before backup.
Tue, Apr 8, 08:07
PiRK requested review of D17906: indexes, refactor: Remove CChainState use in index CommitInternal method.
Tue, Apr 8, 07:27

Mon, Apr 7

PiRK closed D17899: validation: do not activate snapshot if behind active chain.
Mon, Apr 7, 13:57
PiRK committed rABC9334ff0cbd5f: validation: do not activate snapshot if behind active chain (authored by James O'Beirne <james.obeirne@pm.me>).
validation: do not activate snapshot if behind active chain
Mon, Apr 7, 13:57
PiRK closed D17897: validation: assumeutxo: swap m_mempool on snapshot activation.
Mon, Apr 7, 13:57
PiRK closed D17898: refuse to activate a UTXO snapshot if mempool not empty.
Mon, Apr 7, 13:57
PiRK committed rABC960dac9a7937: refuse to activate a UTXO snapshot if mempool not empty (authored by James O'Beirne <james.obeirne@pm.me>).
refuse to activate a UTXO snapshot if mempool not empty
Mon, Apr 7, 13:57
PiRK committed rABC0631de341095: validation: assumeutxo: swap m_mempool on snapshot activation (authored by James O'Beirne <james.obeirne@pm.me>).
validation: assumeutxo: swap m_mempool on snapshot activation
Mon, Apr 7, 13:57
PiRK closed D17896: blockstorage: segment normal/assumedvalid blockfiles.
Mon, Apr 7, 13:57
PiRK closed D17895: validation: pruning for multiple chainstates.
Mon, Apr 7, 13:57
PiRK committed rABC5d870c3dab91: blockstorage: segment normal/assumedvalid blockfiles (authored by James O'Beirne <james.obeirne@pm.me>).
blockstorage: segment normal/assumedvalid blockfiles
Mon, Apr 7, 13:57
PiRK committed rABCa81f203d3013: validation: pruning for multiple chainstates (authored by James O'Beirne <james.obeirne@gmail.com>).
validation: pruning for multiple chainstates
Mon, Apr 7, 13:56
PiRK closed D17894: validation: indexing changes for assumeutxo.
Mon, Apr 7, 13:56
PiRK committed rABC963062a18938: validation: indexing changes for assumeutxo (authored by James O'Beirne <james.obeirne@gmail.com>).
validation: indexing changes for assumeutxo
Mon, Apr 7, 13:56
PiRK closed D17904: tests: Don't make any wallets unless wallet is required.
Mon, Apr 7, 13:42
PiRK committed rABC3217c6aae8ba: tests: Don't make any wallets unless wallet is required (authored by Andrew Chow <achow101-github@achow101.com>).
tests: Don't make any wallets unless wallet is required
Mon, Apr 7, 13:42
PiRK added inline comments to D17904: tests: Don't make any wallets unless wallet is required.
Mon, Apr 7, 12:54
PiRK requested review of D17904: tests: Don't make any wallets unless wallet is required.
Mon, Apr 7, 12:47
PiRK updated the diff for D17895: validation: pruning for multiple chainstates.

remove unused forward-declaration, add monitoring the datadir size to the test plan

Mon, Apr 7, 11:03
PiRK updated the test plan for D17896: blockstorage: segment normal/assumedvalid blockfiles.
Mon, Apr 7, 10:58
PiRK updated the diff for D17894: validation: indexing changes for assumeutxo.

avoid taking the lock twice in base.cpp

Mon, Apr 7, 10:50
PiRK closed D17902: test: improve generation of conflicting transactions rpc_gettransactionstatus.
Mon, Apr 7, 10:48
PiRK committed rABC75a7d07cc835: test: improve generation of conflicting transactions rpc_gettransactionstatus (authored by PiRK).
test: improve generation of conflicting transactions rpc_gettransactionstatus
Mon, Apr 7, 10:48
PiRK closed D17901: test: don't pad_tx in MiniWallet.sign_tx.
Mon, Apr 7, 10:48
PiRK committed rABC9492ec7874c5: test: don't pad_tx in MiniWallet.sign_tx (authored by PiRK).
test: don't pad_tx in MiniWallet.sign_tx
Mon, Apr 7, 10:48
PiRK added inline comments to D17894: validation: indexing changes for assumeutxo.
Mon, Apr 7, 10:26
PiRK updated the test plan for D17902: test: improve generation of conflicting transactions rpc_gettransactionstatus.
Mon, Apr 7, 09:48

Sat, Apr 5

PiRK requested review of D17901: test: don't pad_tx in MiniWallet.sign_tx.
Sat, Apr 5, 15:47
PiRK planned changes to D17901: test: don't pad_tx in MiniWallet.sign_tx.
Sat, Apr 5, 15:44
PiRK requested review of D17902: test: improve generation of conflicting transactions rpc_gettransactionstatus.
Sat, Apr 5, 15:41
PiRK updated the summary of D17901: test: don't pad_tx in MiniWallet.sign_tx.
Sat, Apr 5, 15:25
PiRK updated the diff for D17901: test: don't pad_tx in MiniWallet.sign_tx.

fix rebase accident (deterministic arg to pad_tx comes later)

Sat, Apr 5, 15:23
PiRK requested review of D17901: test: don't pad_tx in MiniWallet.sign_tx.
Sat, Apr 5, 15:15

Fri, Apr 4

PiRK requested review of D17899: validation: do not activate snapshot if behind active chain.
Fri, Apr 4, 14:43
PiRK updated the diff for D17898: refuse to activate a UTXO snapshot if mempool not empty.

actually we do have a test. Edit the test plan

Fri, Apr 4, 14:09
PiRK updated the test plan for D17898: refuse to activate a UTXO snapshot if mempool not empty.
Fri, Apr 4, 14:05
PiRK requested review of D17898: refuse to activate a UTXO snapshot if mempool not empty.
Fri, Apr 4, 14:04
PiRK requested review of D17897: validation: assumeutxo: swap m_mempool on snapshot activation.
Fri, Apr 4, 13:57
PiRK updated the diff for D17896: blockstorage: segment normal/assumedvalid blockfiles.

squash couple of commits from core#28562

Fri, Apr 4, 13:43
PiRK planned changes to D17896: blockstorage: segment normal/assumedvalid blockfiles.

there are some changes to be added from core#28562

Fri, Apr 4, 13:37
PiRK requested review of D17896: blockstorage: segment normal/assumedvalid blockfiles.
Fri, Apr 4, 13:29
PiRK requested review of D17895: validation: pruning for multiple chainstates.
Fri, Apr 4, 13:24
PiRK accepted D17893: [explorer] Hide the advanced transaction data by default.
Fri, Apr 4, 13:22
PiRK requested review of D17894: validation: indexing changes for assumeutxo.
Fri, Apr 4, 12:50
PiRK closed D17892: net_processing: validationinterface: ignore some events for bg chain.
Fri, Apr 4, 12:14
PiRK closed D17891: validationinterface: only send zmq notifications for active.
Fri, Apr 4, 12:14
PiRK committed rABCa2d27fa0a73c: validationinterface: only send zmq notifications for active (authored by James O'Beirne <james.obeirne@pm.me>).
validationinterface: only send zmq notifications for active
Fri, Apr 4, 12:14
PiRK committed rABC5437e00b1ea8: net_processing: validationinterface: ignore some events for bg chain (authored by James O'Beirne <james.obeirne@pm.me>).
net_processing: validationinterface: ignore some events for bg chain
Fri, Apr 4, 12:14
PiRK closed D17890: validation: pass ChainstateRole for validationinterface calls.
Fri, Apr 4, 12:14
PiRK committed rABCaefa604d1845: validation: pass ChainstateRole for validationinterface calls (authored by James O'Beirne <james.obeirne@pm.me>).
validation: pass ChainstateRole for validationinterface calls
Fri, Apr 4, 12:14
PiRK committed rABC1fe0d049d7b0: validation: only call UpdatedBlockTip for active chainstate (authored by James O'Beirne <james.obeirne@pm.me>).
validation: only call UpdatedBlockTip for active chainstate
Fri, Apr 4, 12:14
PiRK closed D17889: validation: only call UpdatedBlockTip for active chainstate.
Fri, Apr 4, 12:14
PiRK closed D17888: validation: MaybeRebalanceCaches when chain leaves IBD.
Fri, Apr 4, 12:14
PiRK committed rABC1b41820c0178: validation: MaybeRebalanceCaches when chain leaves IBD (authored by James O'Beirne <james.obeirne@pm.me>).
validation: MaybeRebalanceCaches when chain leaves IBD
Fri, Apr 4, 12:14

Thu, Apr 3

PiRK updated the diff for D17890: validation: pass ChainstateRole for validationinterface calls.

remove unused include in validation_interface_tests, use a forward declaration in other moudles where we currently rely on an implicit inclusion via validation.h

Thu, Apr 3, 19:41
PiRK added inline comments to D17890: validation: pass ChainstateRole for validationinterface calls.
Thu, Apr 3, 19:22
PiRK requested review of D17892: net_processing: validationinterface: ignore some events for bg chain.
Thu, Apr 3, 14:15
PiRK accepted D17887: [website] Fix path to README in fetch_documentation.sh.
Thu, Apr 3, 13:47
PiRK requested review of D17891: validationinterface: only send zmq notifications for active.
Thu, Apr 3, 13:46
PiRK updated the diff for D17890: validation: pass ChainstateRole for validationinterface calls.

revert unrelated blank line changes

Thu, Apr 3, 13:43
PiRK accepted D17885: [herald] Parse kryptex pool.
Thu, Apr 3, 13:39
PiRK requested review of D17890: validation: pass ChainstateRole for validationinterface calls.
Thu, Apr 3, 13:38
PiRK requested review of D17889: validation: only call UpdatedBlockTip for active chainstate.
Thu, Apr 3, 13:31
PiRK requested review of D17888: validation: MaybeRebalanceCaches when chain leaves IBD.
Thu, Apr 3, 13:21
First
Prev
Next