Page MenuHomePhabricator
Feed All Stories

Dec 12 2024

roqqit accepted D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Dec 12 2024, 20:18
Fabien updated the summary of D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Dec 12 2024, 20:18
Fabien requested review of D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Dec 12 2024, 20:16
teamcity closed T3701: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Resolved.
Dec 12 2024, 17:45
teamcity triaged T3702: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Dec 12 2024, 17:45
roqqit closed D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Dec 12 2024, 17:34
roqqit committed rABC44da17657e7c: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup (authored by roqqit).
[avalanche] Restrict scope of cs_stakingRewards lock during cleanup
Dec 12 2024, 17:34
teamcity triaged T3701: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
Dec 12 2024, 15:25
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 12 2024, 15:04
bytesofman closed D17339: [mock-chronik-client] remember to bump the version.
Dec 12 2024, 15:04
bytesofman committed rABC4ef363d2152a: [mock-chronik-client] remember to bump the version (authored by bytesofman).
[mock-chronik-client] remember to bump the version
Dec 12 2024, 15:04
Fabien accepted D17314: [chronik] add a test for the new JSON RPC interface.
Dec 12 2024, 14:55
PiRK accepted D17339: [mock-chronik-client] remember to bump the version.
Dec 12 2024, 13:46
bytesofman published D17339: [mock-chronik-client] remember to bump the version for review.
Dec 12 2024, 13:23
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

stop storing script and scriptHex as these can always be returned accurately by method

Dec 12 2024, 13:22
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 12 2024, 13:21
bytesofman closed D17338: [mock-chronik-client] Remember to build before publishing.
Dec 12 2024, 12:59
bytesofman committed rABC900af67082a6: [mock-chronik-client] Remember to build before publishing (authored by bytesofman).
[mock-chronik-client] Remember to build before publishing
Dec 12 2024, 12:59
PiRK added inline comments to D17314: [chronik] add a test for the new JSON RPC interface.
Dec 12 2024, 12:29
PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

raise an error if response data is too large, improve doc for ChronikElectrumClient with code samples, remove unneed id param for MethodNameProxy

Dec 12 2024, 12:26
Fabien closed D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 12:13
Fabien committed rABC67384414e3f9: [chronik] Add support for TLS to the electrum server (authored by Fabien).
[chronik] Add support for TLS to the electrum server
Dec 12 2024, 12:13
Sheima78 awarded T476: Write a script to automate the collection of gitian outputs a Yellow Medal token.
Dec 12 2024, 11:38 ยท Restricted Project
tobias_ruck accepted D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 11:08
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Improve doc, var names and use .min()

Dec 12 2024, 11:00
tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 10:37
Fabien accepted D17338: [mock-chronik-client] Remember to build before publishing.
Dec 12 2024, 10:05
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 12 2024, 10:05
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 12 2024, 10:04
Fabien requested changes to D17337: [avalanche] Set local stake winner in the contender cache.

Questions more than requesting changes

Dec 12 2024, 09:59
Fabien accepted D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Dec 12 2024, 09:52
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Rebase

Dec 12 2024, 09:50
teamcity added a comment to D17333: [chronik] Add support for TLS to the electrum server.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Dec 12 2024, 09:47
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Feedback

Dec 12 2024, 09:46
Fabien added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 09:45
tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 09:05
bytesofman published D17338: [mock-chronik-client] Remember to build before publishing for review.
Dec 12 2024, 06:06
bytesofman closed D17332: [mock-chronik-client] implement ts.
Dec 12 2024, 04:02
bytesofman committed rABC31d2229d41aa: [mock-chronik-client] implement ts (authored by bytesofman).
[mock-chronik-client] implement ts
Dec 12 2024, 04:02
emack accepted D17332: [mock-chronik-client] implement ts.
Dec 12 2024, 02:01
hazzarust added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

This is Tobias' client, the one we use for the explorer. @hazzarust is putting it into the monorepo then will add the failover proxy to it.

ok nice

in that case, not really a big deal about adding stuff like test comments, having this as a starting point is helpful

Dec 12 2024, 01:19

Dec 11 2024

roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
Dec 11 2024, 23:43
bytesofman added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

This is Tobias' client, the one we use for the explorer. @hazzarust is putting it into the monorepo then will add the failover proxy to it.

Dec 11 2024, 20:21
Fabien added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

Dec 11 2024, 20:14
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 11 2024, 20:14
bytesofman requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

Dec 11 2024, 19:17
roqqit requested review of D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Dec 11 2024, 17:48
hazzarust updated the summary of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 11 2024, 16:02
hazzarust updated the test plan for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 11 2024, 15:59
hazzarust requested review of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 11 2024, 15:59
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 11 2024, 13:28
bytesofman updated the diff for D17332: [mock-chronik-client] implement ts.

improve cashtab test mock prep implementation

Dec 11 2024, 13:10
bytesofman added inline comments to D17332: [mock-chronik-client] implement ts.
Dec 11 2024, 13:08
hazzarust closed D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Dec 11 2024, 12:31
hazzarust committed rABC5dbda19390ac: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer. (authored by hazzarust).
[BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.
Dec 11 2024, 12:31
tobias_ruck accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Dec 11 2024, 12:05
PiRK added inline comments to D17314: [chronik] add a test for the new JSON RPC interface.
Dec 11 2024, 11:56
Fabien accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Dec 11 2024, 11:55
teamcity awarded D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile` a Doubloon token.
Dec 11 2024, 10:43
Fabien added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Dec 11 2024, 10:43
Fabien requested changes to D17314: [chronik] add a test for the new JSON RPC interface.

The API is now very good imo

Dec 11 2024, 10:37
hazzarust updated the diff for D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

fixed indentation issue (timeout was indented in script, removed indentation)

Dec 11 2024, 10:33
emack requested changes to D17332: [mock-chronik-client] implement ts.
Dec 11 2024, 10:27
PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

rework the API, use a client object similar to ChronikClient, set a timeout for the socket so that we get an error if the server never replies (or never sends the final \n)

Dec 11 2024, 09:18
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 11 2024, 09:14
Fabien requested changes to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

Make sure to run the test plan yourself

Dec 11 2024, 08:42
johnkuney closed D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Dec 11 2024, 05:19
johnkuney committed rABC931c83b45e5a: [e.cash] Add openInNewTab prop to /use-ecash buttons (authored by johnkuney).
[e.cash] Add openInNewTab prop to /use-ecash buttons
Dec 11 2024, 05:19
bytesofman accepted D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Dec 11 2024, 05:02
bytesofman added inline comments to D17332: [mock-chronik-client] implement ts.
Dec 11 2024, 05:01
bytesofman updated the diff for D17332: [mock-chronik-client] implement ts.

Better comments on classes in mock-chronik-client

Dec 11 2024, 04:59
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

improve organization of address.test.ts

Dec 11 2024, 04:42
johnkuney requested review of D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Dec 11 2024, 04:35
bytesofman closed D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Dec 11 2024, 02:31
bytesofman committed rABC567d1dff4119: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode (authored by bytesofman).
[chronik-client] Add support for validate-tx endpoint to ChronikClientNode
Dec 11 2024, 02:31
bytesofman added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

ok after leaving this for a day or two then looking at it again, understand the constructor overloading comment. cleaned it up, updated tests.

Dec 11 2024, 02:25
bytesofman published D17332: [mock-chronik-client] implement ts for review.
Dec 11 2024, 02:24
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

make constructor private, stop supporting so many input types, no overloaded constructor, better test organization

Dec 11 2024, 02:13
emack accepted D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Dec 11 2024, 01:52
bytesofman updated the summary of D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 11 2024, 01:35

Dec 10 2024

teamcity added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Dec 10 2024, 21:12
teamcity awarded D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile` a Piece of Eight token.
Dec 10 2024, 21:08
tobias_ruck added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Dec 10 2024, 21:07
teamcity closed T3700: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Dec 10 2024, 20:59
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Fix a typo

Dec 10 2024, 20:21
Fabien updated the test plan for D17333: [chronik] Add support for TLS to the electrum server.
Dec 10 2024, 20:19
roqqit closed D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 19:57
roqqit committed rABCe9d7a6220c01: Add symlink to most recent functional test failure directory (authored by roqqit).
Add symlink to most recent functional test failure directory
Dec 10 2024, 19:57
PiRK accepted D17333: [chronik] Add support for TLS to the electrum server.
Dec 10 2024, 19:48
Fabien accepted D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 19:31
hazzarust set Slack Username to Harry on hazzarust.
Dec 10 2024, 19:06
teamcity triaged T3700: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Dec 10 2024, 19:04
roqqit closed D17330: Run more functional tests in parallel by default.
Dec 10 2024, 18:08
roqqit committed rABC8917a6f8af6c: Run more functional tests in parallel by default (authored by roqqit).
Run more functional tests in parallel by default
Dec 10 2024, 18:08
roqqit updated the test plan for D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 17:36
roqqit updated the diff for D17331: Add symlink to most recent functional test failure directory.
  • move lastfailure to top of build_dir
  • ignore OSError exceptions on windows (didn't use contextlib.suppress because I don't think we should ignore it on Linux)
Dec 10 2024, 17:36
Fabien added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Dec 10 2024, 17:19
PiRK added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Dec 10 2024, 17:08
roqqit planned changes to D17331: Add symlink to most recent functional test failure directory.
Dec 10 2024, 16:51
roqqit closed D17329: Remove incorrect note in functional tests doc.
Dec 10 2024, 16:48