Page MenuHomePhabricator
Feed All Stories

Mon, Apr 21

Fabien committed rABC26455ff9feb4: send: refactor CreateTransaction flow to return a BResult<CTransactionRef> (authored by furszy <matiasfurszyfer@protonmail.com>).
send: refactor CreateTransaction flow to return a BResult<CTransactionRef>
Mon, Apr 21, 11:37
Fabien committed rABCf1a8ad562a9c: wallet: refactor GetNewDestination, use BResult (authored by furszy <matiasfurszyfer@protonmail.com>).
wallet: refactor GetNewDestination, use BResult
Mon, Apr 21, 11:37
PiRK accepted D17957: wallet: refactor GetNewDestination, use BResult.
Mon, Apr 21, 11:33
PiRK accepted D17956: send: refactor CreateTransaction flow to return a BResult<CTransactionRef>.
Mon, Apr 21, 11:23
teamcity updated the summary of D17957: wallet: refactor GetNewDestination, use BResult.
Mon, Apr 21, 10:42
Fabien requested review of D17957: wallet: refactor GetNewDestination, use BResult.
Mon, Apr 21, 10:42
teamcity updated the summary of D17956: send: refactor CreateTransaction flow to return a BResult<CTransactionRef>.
Mon, Apr 21, 09:51
Fabien requested review of D17956: send: refactor CreateTransaction flow to return a BResult<CTransactionRef>.
Mon, Apr 21, 09:51
Fabien closed D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Mon, Apr 21, 08:11
Fabien committed rABC4d8d31e7604a: wallet, refactor: return out-params of CreateTransaction() as optional struct (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
wallet, refactor: return out-params of CreateTransaction() as optional struct
Mon, Apr 21, 08:11
Fabien added inline comments to D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Mon, Apr 21, 08:06
PiRK accepted D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Mon, Apr 21, 06:20

Sun, Apr 20

abc-bot committed rABCabf469b24e78: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Apr 20, 21:16
abc-bot committed rABC83f19fdff601: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Apr 20, 21:08
Fabien updated subscribers of D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Sun, Apr 20, 20:40
Fabien requested changes to D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Some minor change requested, looks mostly good !

Sun, Apr 20, 20:26
Fabien added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Sun, Apr 20, 19:50
Fabien updated the diff for D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.

Fix comment

Sun, Apr 20, 19:46
Fabien closed D17953: rpc: Add specific error code for "wallet already loaded".
Sun, Apr 20, 19:42
Fabien committed rABC27e36bd3a7f4: rpc: Add specific error code for "wallet already loaded" (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
rpc: Add specific error code for "wallet already loaded"
Sun, Apr 20, 19:42
PiRK planned changes to D17952: refactor: remove ::vpwallets and related global variables.
Sun, Apr 20, 05:47
emack added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Sun, Apr 20, 00:20

Sat, Apr 19

emack added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Sat, Apr 19, 23:46
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 21:48
PiRK updated the summary of D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 21:36
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

squash with core#22992

Sat, Apr 19, 21:36
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

Maybe core#22992

Sat, Apr 19, 19:31
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Finished off the testing for block functionality, improved error handling and removed some questionable comments xd

Sat, Apr 19, 19:06
hazzarust retitled D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client from [chronik] Add websocket.rs integration test to bitcoinsuite-chronik-client to [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Sat, Apr 19, 19:02
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 17:37
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

more clang-tidy issues (argument names)

Sat, Apr 19, 17:21
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 17:17
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 17:09
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

Let's see if the build-debug segfault is happening consistently

Sat, Apr 19, 17:02
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

clang-tidy warnings

Sat, Apr 19, 17:01
PiRK committed rABCd5c9b24c385c: walletdb: don't read db every time that a new WalletBatch is created, fix last… (authored by furszy <matiasfurszyfer@protonmail.com>).
walletdb: don't read db every time that a new WalletBatch is created, fix last…
Sat, Apr 19, 16:48
PiRK closed D17951: walletdb: don't read db every time that a new WalletBatch is created, fix last client version update.
Sat, Apr 19, 16:48
PiRK requested changes to D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Sat, Apr 19, 16:47
PiRK accepted D17953: rpc: Add specific error code for "wallet already loaded".
Sat, Apr 19, 16:45
teamcity added a comment to D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Sat, Apr 19, 14:31
teamcity added a comment to D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Sat, Apr 19, 14:30
teamcity updated the summary of D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Sat, Apr 19, 14:28
Fabien requested review of D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Sat, Apr 19, 14:28
teamcity updated the summary of D17953: rpc: Add specific error code for "wallet already loaded".
Sat, Apr 19, 12:34
Fabien requested review of D17953: rpc: Add specific error code for "wallet already loaded".
Sat, Apr 19, 12:34
Fabien accepted D17951: walletdb: don't read db every time that a new WalletBatch is created, fix last client version update.
Sat, Apr 19, 11:57
PiRK planned changes to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 11:02
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 09:00
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 08:53
teamcity added a comment to D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 08:48
teamcity awarded D17952: refactor: remove ::vpwallets and related global variables a Haypence token.
Sat, Apr 19, 08:45
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

@bot build-asan

Sat, Apr 19, 08:44
teamcity updated the summary of D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 08:44
PiRK requested review of D17952: refactor: remove ::vpwallets and related global variables.
Sat, Apr 19, 08:44
teamcity updated the summary of D17951: walletdb: don't read db every time that a new WalletBatch is created, fix last client version update.
Sat, Apr 19, 06:39
PiRK requested review of D17951: walletdb: don't read db every time that a new WalletBatch is created, fix last client version update.
Sat, Apr 19, 06:39

Fri, Apr 18

Fabien closed D17950: [avalanche] Fix stake contender unit test occasional failure.
Fri, Apr 18, 22:01
Fabien committed rABCdc7fa3c5d71e: [avalanche] Fix stake contender unit test occasional failure (authored by Fabien).
[avalanche] Fix stake contender unit test occasional failure
Fri, Apr 18, 22:01
PiRK accepted D17950: [avalanche] Fix stake contender unit test occasional failure.
Fri, Apr 18, 19:16
alitayin added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 17:27
alitayin retitled D17949: [chronik-client] Add handling for WebSocket closure from [chronik-client] Add handling for WebSocket closure and add delay for reconnection to [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 17:12
alitayin updated the summary of D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 17:12
alitayin updated the diff for D17949: [chronik-client] Add handling for WebSocket closure .

keep the first modification to close WS

Fri, Apr 18, 17:10
bytesofman requested changes to D17949: [chronik-client] Add handling for WebSocket closure .
  • As @emack mentioned, this is 2 diffs. Please make one diff to add the close, and another to add the delay
  • npm test does not actually test the behavior described in this diff. If it is impractical to add a unit or integration test, the test plan should include a description of how to repeat the issue before this change, and how to demonstrate that the issue is resolved after this change. Then npm test is demonstrating that existing behavior is preserved with this patch.
  • patch version bump npm version patch (can be for just the 2nd of these 2 diffs, or can be a separate npm version patch for each diff), update changelog section of README describing the change
Fri, Apr 18, 16:39
Fabien requested review of D17950: [avalanche] Fix stake contender unit test occasional failure.
Fri, Apr 18, 14:45
emack requested changes to D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 12:14
alitayin requested review of D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 03:27

Thu, Apr 17

alitayin closed D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 17, 23:33
alitayin committed rABC0eaa9c9c1589: [chronik-client] Added a mechanism for automatically selecting the fastest… (authored by alitayin).
[chronik-client] Added a mechanism for automatically selecting the fastest…
Thu, Apr 17, 23:33
bytesofman added inline comments to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.
Thu, Apr 17, 23:32
bytesofman accepted D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 17, 23:28
teamcity triaged T3785: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Thu, Apr 17, 21:08
PiRK closed D17948: rpc: Include assumeutxo as a failure reason of rescanblockchain.
Thu, Apr 17, 20:32
PiRK committed rABCcfca26a80a31: rpc: Include assumeutxo as a failure reason of rescanblockchain (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Include assumeutxo as a failure reason of rescanblockchain
Thu, Apr 17, 20:32
PiRK closed D17931: add loadtxoutset & getchainstates RPCs, add functional tests.
Thu, Apr 17, 20:32
PiRK committed rABCdc73f741fad1: add loadtxoutset & getchainstates RPCs, add functional tests (authored by James O'Beirne <james.obeirne@gmail.com>).
add loadtxoutset & getchainstates RPCs, add functional tests
Thu, Apr 17, 20:32
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

rebase so i can do arc land --revision D17931 (apparently to force a revision the commit must match )

Thu, Apr 17, 20:30
PiRK closed D17947: RPC: access RPC arguments by name.
Thu, Apr 17, 20:26
PiRK committed rABC977989ed441c: RPC: access RPC arguments by name (authored by stickies-v <stickies-v@protonmail.com>).
RPC: access RPC arguments by name
Thu, Apr 17, 20:26
PiRK closed D17946: rpc, refactor: clean-up `addnode`.
Thu, Apr 17, 20:26
PiRK committed rABC159c0dc33237: rpc, refactor: clean-up `addnode` (authored by brunoerg <brunoely.gc@gmail.com>).
rpc, refactor: clean-up `addnode`
Thu, Apr 17, 20:26
Fabien accepted D17948: rpc: Include assumeutxo as a failure reason of rescanblockchain.
Thu, Apr 17, 18:33
Fabien accepted D17947: RPC: access RPC arguments by name.
Thu, Apr 17, 18:32
Fabien accepted D17946: rpc, refactor: clean-up `addnode`.

nvm

Thu, Apr 17, 18:29
Fabien added inline comments to D17946: rpc, refactor: clean-up `addnode`.
Thu, Apr 17, 18:28
Fabien accepted D17931: add loadtxoutset & getchainstates RPCs, add functional tests.
Thu, Apr 17, 18:25
Fabien accepted D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 17, 18:24
johnkuney closed D17941: [cashtab] CSS tweak for default desktop agora view.
Thu, Apr 17, 16:05
johnkuney committed rABC589bdef2aeb0: [cashtab] CSS tweak for default desktop agora view (authored by johnkuney).
[cashtab] CSS tweak for default desktop agora view
Thu, Apr 17, 16:05
johnkuney updated the diff for D17941: [cashtab] CSS tweak for default desktop agora view.

prop name edit

Thu, Apr 17, 16:05
PiRK updated the diff for D17947: RPC: access RPC arguments by name.

remove accidental character in doxygen doc

Thu, Apr 17, 15:39
teamcity added a comment to D17947: RPC: access RPC arguments by name.
Thu, Apr 17, 15:38
bytesofman accepted D17941: [cashtab] CSS tweak for default desktop agora view.

nit, the offer usually refers to the actual AgoraOffer, but in this case we want to specify that we mean a count

Thu, Apr 17, 15:36
PiRK added inline comments to D17947: RPC: access RPC arguments by name.
Thu, Apr 17, 15:35
teamcity updated the summary of D17948: rpc: Include assumeutxo as a failure reason of rescanblockchain.
Thu, Apr 17, 15:35
PiRK requested review of D17948: rpc: Include assumeutxo as a failure reason of rescanblockchain.
Thu, Apr 17, 15:35
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

url in RPC doc

Thu, Apr 17, 15:32
teamcity updated the summary of D17947: RPC: access RPC arguments by name.
Thu, Apr 17, 15:29
PiRK requested review of D17947: RPC: access RPC arguments by name.
Thu, Apr 17, 15:29
johnkuney added a comment to D17941: [cashtab] CSS tweak for default desktop agora view.

ah sure, added

Thu, Apr 17, 15:22